Commit eb19acb
test: fix misleading comment
The comment is outdated, function declarations have
nothing to do with defineProperties.
PR-URL: #12048
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 9dda771 commit eb19acb
1 file changed
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,11 +5,9 @@ const assert = require('assert'); | |||
| 5 | 5 | const vm = require('vm'); | |
| 6 | 6 | const o = vm.createContext({ console: console }); | |
| 7 | 7 | ||
| 8 | - // This triggers the setter callback in node_contextify.cc | ||
| 8 | + // Function declaration and expression should both be copied to the | ||
| 9 | + // sandboxed context. | ||
| 9 | 10 | let code = 'var a = function() {};\n'; | |
| 10 | - | ||
| 11 | - // but this does not, since function decls are defineProperties, | ||
| 12 | - // not simple sets. | ||
| 13 | 11 | code += 'function b(){}\n'; | |
| 14 | 12 | ||
| 15 | 13 | // Grab the global b function as the completion value, to ensure that | |
0 commit comments