test: fix Windows compiler warnings in overlapped-checker · nodejs/node@eb53121 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit eb53121

Browse filesBrowse the repository at this point in the historyBrowse files

targos

authored

test: fix Windows compiler warnings in overlapped-checker

Fixes two warnings: - test\overlapped-checker\main_win.c(37,25): warning : format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned long') [-Wformat] - test\overlapped-checker\main_win.c(9,14): warning : unused variable 'write_count' [-Wunused-variable] PR-URL: #52405 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

1 parent a760dad commit eb53121
Copy full SHA for eb53121

1 file changed

+1-2Lines changed: 1 addition & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/overlapped-checker
  • main_win.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/overlapped-checker/main_win.c‎

Copy file name to clipboardExpand all lines: test/overlapped-checker/main_win.c

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -6,7 +6,6 @@
6	6
7	7	static char buf[256];
8	8	static DWORD read_count;
9		- static DWORD write_count;
10	9	static HANDLE stdin_h;
11	10	static OVERLAPPED stdin_o;
12	11
@@ -34,7 +33,7 @@ static void write(const char* buf, size_t buf_size) {
34	33	if (!WriteFile(stdout_h, buf, buf_size, &write_count, NULL)) {
35	34	die("overlapped write failed");
36	35	}
37		- fprintf(stderr, "%d", write_count);
	36	+ fprintf(stderr, "%ld", write_count);
38	37	fflush(stderr);
39	38	}
40	39

0 commit comments

Comments

0 (0)