Commit eb7b89c
committed
lib: update class fields TODO in abort_controller.js
https://bugs.chromium.org/p/v8/issues/detail?id=10704 is already
fixed, but since AbortController currently throws ERR_INVALID_THIS
we'll revert to class fields in a subsequent patch. For now just
update the comments.
PR-URL: #42361
Refs: b1c3909
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 9680d7d commit eb7b89c
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -291,9 +291,8 @@ function abortSignal(signal, reason) { | |||
| 291 | 291 | signal.dispatchEvent(event); | |
| 292 | 292 | } | |
| 293 | 293 | ||
| 294 | - // TODO(joyeecheung): V8 snapshot does not support instance member | ||
| 295 | - // initializers for now: | ||
| 296 | - // https://bugs.chromium.org/p/v8/issues/detail?id=10704 | ||
| 294 | + // TODO(joyeecheung): use private fields and we'll get invalid access | ||
| 295 | + // validation from V8 instead of throwing ERR_INVALID_THIS ourselves. | ||
| 297 | 296 | const kSignal = Symbol('signal'); | |
| 298 | 297 | ||
| 299 | 298 | function validateAbortController(obj) { | |
0 commit comments