benchmark: remove forced optimization from path · nodejs/node@eba2c62 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 37.5k
• Star 122k

• Code
• Issues 615
• Pull requests 570
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit eba2c62

Browse filesBrowse the repository at this point in the historyBrowse files

bzoz

committed

benchmark: remove forced optimization from path

This removes all instances of %OptimizeFunctionOnNextCall from path benchmarks PR-URL: #9615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 parent 7587a11 commit eba2c62
Copy full SHA for eba2c62

21 files changed

+17-150Lines changed: 17 additions & 150 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• benchmark/path
  • basename-posix.js
  • basename-win32.js
  • dirname-posix.js
  • dirname-win32.js
  • extname-posix.js
  • extname-win32.js
  • format-posix.js
  • format-win32.js
  • isAbsolute-posix.js
  • isAbsolute-win32.js
  • join-posix.js
  • join-win32.js
  • makeLong-win32.js
  • normalize-posix.js
  • normalize-win32.js
  • parse-posix.js
  • parse-win32.js
  • relative-posix.js
  • relative-win32.js
  • resolve-posix.js
  • resolve-win32.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎benchmark/path/basename-posix.js‎

Copy file name to clipboardExpand all lines: benchmark/path/basename-posix.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	pathext: [
@@ -30,12 +29,6 @@ function main(conf) {
30	29	input = input.slice(0, extIdx);
31	30	}
32	31
33		- // Force optimization before starting the benchmark
34		- p.basename(input, ext);
35		- v8.setFlagsFromString('--allow_natives_syntax');
36		- eval('%OptimizeFunctionOnNextCall(p.basename)');
37		- p.basename(input, ext);
38		-
39	32	bench.start();
40	33	for (var i = 0; i < n; i++) {
41	34	p.basename(input, ext);

Collapse file

‎benchmark/path/basename-win32.js‎

Copy file name to clipboardExpand all lines: benchmark/path/basename-win32.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	pathext: [
@@ -30,12 +29,6 @@ function main(conf) {
30	29	input = input.slice(0, extIdx);
31	30	}
32	31
33		- // Force optimization before starting the benchmark
34		- p.basename(input, ext);
35		- v8.setFlagsFromString('--allow_natives_syntax');
36		- eval('%OptimizeFunctionOnNextCall(p.basename)');
37		- p.basename(input, ext);
38		-
39	32	bench.start();
40	33	for (var i = 0; i < n; i++) {
41	34	p.basename(input, ext);

Collapse file

‎benchmark/path/dirname-posix.js‎

Copy file name to clipboardExpand all lines: benchmark/path/dirname-posix.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	path: [
@@ -21,12 +20,6 @@ function main(conf) {
21	20	var p = path.posix;
22	21	var input = '' + conf.path;
23	22
24		- // Force optimization before starting the benchmark
25		- p.dirname(input);
26		- v8.setFlagsFromString('--allow_natives_syntax');
27		- eval('%OptimizeFunctionOnNextCall(p.dirname)');
28		- p.dirname(input);
29		-
30	23	bench.start();
31	24	for (var i = 0; i < n; i++) {
32	25	p.dirname(input);

Collapse file

‎benchmark/path/dirname-win32.js‎

Copy file name to clipboardExpand all lines: benchmark/path/dirname-win32.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	path: [
@@ -21,12 +20,6 @@ function main(conf) {
21	20	var p = path.win32;
22	21	var input = '' + conf.path;
23	22
24		- // Force optimization before starting the benchmark
25		- p.dirname(input);
26		- v8.setFlagsFromString('--allow_natives_syntax');
27		- eval('%OptimizeFunctionOnNextCall(p.dirname)');
28		- p.dirname(input);
29		-
30	23	bench.start();
31	24	for (var i = 0; i < n; i++) {
32	25	p.dirname(input);

Collapse file

‎benchmark/path/extname-posix.js‎

Copy file name to clipboardExpand all lines: benchmark/path/extname-posix.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	path: [
@@ -24,12 +23,6 @@ function main(conf) {
24	23	var p = path.posix;
25	24	var input = '' + conf.path;
26	25
27		- // Force optimization before starting the benchmark
28		- p.extname(input);
29		- v8.setFlagsFromString('--allow_natives_syntax');
30		- eval('%OptimizeFunctionOnNextCall(p.extname)');
31		- p.extname(input);
32		-
33	26	bench.start();
34	27	for (var i = 0; i < n; i++) {
35	28	p.extname(input);

Collapse file

‎benchmark/path/extname-win32.js‎

Copy file name to clipboardExpand all lines: benchmark/path/extname-win32.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	path: [
@@ -24,12 +23,6 @@ function main(conf) {
24	23	var p = path.win32;
25	24	var input = '' + conf.path;
26	25
27		- // Force optimization before starting the benchmark
28		- p.extname(input);
29		- v8.setFlagsFromString('--allow_natives_syntax');
30		- eval('%OptimizeFunctionOnNextCall(p.extname)');
31		- p.extname(input);
32		-
33	26	bench.start();
34	27	for (var i = 0; i < n; i++) {
35	28	p.extname(input);

Collapse file

‎benchmark/path/format-posix.js‎

Copy file name to clipboardExpand all lines: benchmark/path/format-posix.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	props: [
@@ -22,12 +21,6 @@ function main(conf) {
22	21	name: props[4] || '',
23	22	};
24	23
25		- // Force optimization before starting the benchmark
26		- p.format(obj);
27		- v8.setFlagsFromString('--allow_natives_syntax');
28		- eval('%OptimizeFunctionOnNextCall(p.format)');
29		- p.format(obj);
30		-
31	24	bench.start();
32	25	for (var i = 0; i < n; i++) {
33	26	p.format(obj);

Collapse file

‎benchmark/path/format-win32.js‎

Copy file name to clipboardExpand all lines: benchmark/path/format-win32.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	props: [
@@ -22,12 +21,6 @@ function main(conf) {
22	21	name: props[4] || '',
23	22	};
24	23
25		- // Force optimization before starting the benchmark
26		- p.format(obj);
27		- v8.setFlagsFromString('--allow_natives_syntax');
28		- eval('%OptimizeFunctionOnNextCall(p.format)');
29		- p.format(obj);
30		-
31	24	bench.start();
32	25	for (var i = 0; i < n; i++) {
33	26	p.format(obj);

Collapse file

‎benchmark/path/isAbsolute-posix.js‎

Copy file name to clipboardExpand all lines: benchmark/path/isAbsolute-posix.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	path: [
@@ -19,12 +18,6 @@ function main(conf) {
19	18	var p = path.posix;
20	19	var input = '' + conf.path;
21	20
22		- // Force optimization before starting the benchmark
23		- p.isAbsolute(input);
24		- v8.setFlagsFromString('--allow_natives_syntax');
25		- eval('%OptimizeFunctionOnNextCall(p.isAbsolute)');
26		- p.isAbsolute(input);
27		-
28	21	bench.start();
29	22	for (var i = 0; i < n; i++) {
30	23	p.isAbsolute(input);

Collapse file

‎benchmark/path/isAbsolute-win32.js‎

Copy file name to clipboardExpand all lines: benchmark/path/isAbsolute-win32.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,6 @@
1	1	'use strict';
2	2	var common = require('../common.js');
3	3	var path = require('path');
4		- var v8 = require('v8');
5	4
6	5	var bench = common.createBenchmark(main, {
7	6	path: [
@@ -20,12 +19,6 @@ function main(conf) {
20	19	var p = path.win32;
21	20	var input = '' + conf.path;
22	21
23		- // Force optimization before starting the benchmark
24		- p.isAbsolute(input);
25		- v8.setFlagsFromString('--allow_natives_syntax');
26		- eval('%OptimizeFunctionOnNextCall(p.isAbsolute)');
27		- p.isAbsolute(input);
28		-
29	22	bench.start();
30	23	for (var i = 0; i < n; i++) {
31	24	p.isAbsolute(input);

0 commit comments

Comments

0 (0)