build: on Android, use android log library to print stack traces · nodejs/node@ebe6a55 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ebe6a55

Browse filesBrowse the repository at this point in the historyBrowse files

gcampax

authored and

BethGriggs

committed

build: on Android, use android log library to print stack traces

And other errors like lost promises PR-URL: #29388 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent fbf5bee commit ebe6a55
Copy full SHA for ebe6a55

1 file changed

+6Lines changed: 6 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_errors.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_errors.cc‎

Copy file name to clipboardExpand all lines: src/node_errors.cc

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -10,6 +10,10 @@
10	10	#include "node_v8_platform-inl.h"
11	11	#include "util-inl.h"
12	12
	13	+ #ifdef __ANDROID__
	14	+ #include <android/log.h>
	15	+ #endif
	16	+
13	17	namespace node {
14	18
15	19	using errors::TryCatchScope;
@@ -426,6 +430,8 @@ void PrintErrorString(const char* format, ...) {
426	430	// Don't include the null character in the output
427	431	CHECK_GT(n, 0);
428	432	WriteConsoleW(stderr_handle, wbuf.data(), n - 1, nullptr, nullptr);
	433	+ #elif defined(__ANDROID__)
	434	+ __android_log_vprint(ANDROID_LOG_ERROR, "nodejs", format, ap);
429	435	#else
430	436	vfprintf(stderr, format, ap);
431	437	#endif

0 commit comments

Comments

0 (0)