test_runner: avoid reporting parents of failing tests in summary · nodejs/node@ec24aba · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ec24aba

Browse filesBrowse the repository at this point in the historyBrowse files

MoLow

authored and

targos

committed

test_runner: avoid reporting parents of failing tests in summary

PR-URL: #47579 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 12f0fa3 commit ec24aba
Copy full SHA for ec24aba

4 files changed

+4-25Lines changed: 4 additions & 25 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/test_runner/reporter
  • spec.js
• test
  • fixtures/test-runner/output
    • spec_reporter.snapshot
    • spec_reporter_cli.snapshot
  • pseudo-tty
    • test_runner_default_reporter.out

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/test_runner/reporter/spec.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/reporter/spec.js

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -15,6 +15,7 @@ const assert = require('assert');
15	15	const Transform = require('internal/streams/transform');
16	16	const { inspectWithNoCustomRetry } = require('internal/errors');
17	17	const { green, blue, red, white, gray, hasColors } = require('internal/util/colors');
	18	+ const { kSubtestsFailed } = require('internal/test_runner/test');
18	19	const { getCoverageReport } = require('internal/test_runner/utils');
19	20
20	21	const inspectOptions = { __proto__: null, colors: hasColors, breakLength: Infinity };
@@ -107,7 +108,9 @@ class SpecReporter extends Transform {
107	108	#handleEvent({ type, data }) {
108	109	switch (type) {
109	110	case 'test:fail':
110		- ArrayPrototypePush(this.#failedTests, data);
	111	+ if (data.details?.error?.failureType !== kSubtestsFailed) {
	112	+ ArrayPrototypePush(this.#failedTests, data);
	113	+ }
111	114	return this.#handleTestReportEvent(type, data);
112	115	case 'test:pass':
113	116	return this.#handleTestReportEvent(type, data);

Collapse file

‎test/fixtures/test-runner/output/spec_reporter.snapshot‎

Copy file name to clipboardExpand all lines: test/fixtures/test-runner/output/spec_reporter.snapshot

-9Lines changed: 0 additions & 9 deletions

Original file line number	Diff line number	Diff line change
@@ -399,18 +399,12 @@
399	399	*
400	400	*
401	401
402		- subtest sync throw fail (*ms)
403		- '1 subtest failed'
404		-
405	402	sync throw non-error fail (*ms)
406	403	Symbol(thrown symbol from sync throw non-error fail)
407	404
408	405	+long running (*ms)
409	406	'test did not finish before its parent and was cancelled'
410	407
411		- top level (*ms)
412		- '1 subtest failed'
413		-
414	408	sync skip option is false fail (*ms)
415	409	Error: this should be executed
416	410	*
@@ -487,9 +481,6 @@
487	481	*
488	482	*
489	483
490		- subtest sync throw fails (*ms)
491		- '2 subtests failed'
492		-
493	484	timed out async test (*ms)
494	485	'test timed out after *ms'
495	486

Collapse file

‎test/fixtures/test-runner/output/spec_reporter_cli.snapshot‎

Copy file name to clipboardExpand all lines: test/fixtures/test-runner/output/spec_reporter_cli.snapshot

-12Lines changed: 0 additions & 12 deletions

Original file line number	Diff line number	Diff line change
@@ -408,10 +408,6 @@
408	408	*
409	409	*
410	410
411		- subtest sync throw fail (*ms)
412		- [Error: 1 subtest failed
413		- ]
414		-
415	411	sync throw non-error fail (*ms)
416	412	[Error: Symbol(thrown symbol from sync throw non-error fail)
417	413	]
@@ -420,10 +416,6 @@
420	416	[Error: test did not finish before its parent and was cancelled
421	417	]
422	418
423		- top level (*ms)
424		- [Error: 1 subtest failed
425		- ]
426		-
427	419	sync skip option is false fail (*ms)
428	420	Error: this should be executed
429	421	*
@@ -504,10 +496,6 @@
504	496	*
505	497	*
506	498
507		- subtest sync throw fails (*ms)
508		- [Error: 2 subtests failed
509		- ]
510		-
511	499	timed out async test (*ms)
512	500	[Error: test timed out after *ms
513	501	]

Collapse file

‎test/pseudo-tty/test_runner_default_reporter.out‎

Copy file name to clipboardExpand all lines: test/pseudo-tty/test_runner_default_reporter.out

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -55,6 +55,3 @@
55	55
56	56	[31m* should pass but parent fail [90m(*ms)[39m[39m
57	57	[32m'test did not finish before its parent and was cancelled'[39m
58		-
59		- [31m* parent [90m(*ms)[39m[39m
60		- [32m'2 subtests failed'[39m

0 commit comments

Comments

0 (0)