test: fixup flaky test-performance-function-async test · nodejs/node@ecc5842 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ecc5842

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

committed

test: fixup flaky test-performance-function-async test

The time assertion was inaccurate. Just remove it as it's not strictly necessary PR-URL: #37493 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent 4eec919 commit ecc5842
Copy full SHA for ecc5842

1 file changed

-1Lines changed: 0 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-performance-function-async.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-performance-function-async.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-performance-function-async.js

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -26,7 +26,6 @@ async function doIt() {
26	26	const obs = new PerformanceObserver(common.mustCall((list) => {
27	27	const entry = list.getEntries()[0];
28	28	assert.strictEqual(entry.name, 'doIt');
29		- assert(entry.duration > 100);
30	29	assert(check);
31	30	obs.disconnect();
32	31	}));

0 commit comments

Comments

0 (0)