Commit ecca2b0
deps: define V8_PRESERVE_MOST as no-op on Windows
It's causing linker errors with node.lib in node-gyp and potentially
breaks other 3rd party tools
PR-URL: #56238
Refs: #55784
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 7c8483a commit ecca2b0
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.1', | ||
| 41 | + 'v8_embedder_string': '-node.2', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -600,11 +600,15 @@ path. Add it with -I<path> to the command line | |||
| 600 | 600 | // functions. | |
| 601 | 601 | // Use like: | |
| 602 | 602 | // V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod(); | |
| 603 | + #if V8_OS_WIN | ||
| 604 | + # define V8_PRESERVE_MOST | ||
| 605 | + #else | ||
| 603 | 606 | #if V8_HAS_ATTRIBUTE_PRESERVE_MOST | |
| 604 | 607 | # define V8_PRESERVE_MOST __attribute__((preserve_most)) | |
| 605 | 608 | #else | |
| 606 | 609 | # define V8_PRESERVE_MOST /* NOT SUPPORTED */ | |
| 607 | 610 | #endif | |
| 611 | + #endif | ||
| 608 | 612 | ||
| 609 | 613 | ||
| 610 | 614 | // A macro (V8_DEPRECATED) to mark classes or functions as deprecated. | |
0 commit comments