Commit ed029bd
committed
deps: avoid compilation error with ASan
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: #49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #54077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent e600de9 commit ed029bd
2 files changed
Lines changed: 13 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.2', | ||
| 39 | + 'v8_embedder_string': '-node.3', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -696,24 +696,24 @@ | |||
| 696 | 696 | #define WRITE_BARRIER(object, offset, value) | |
| 697 | 697 | #define WRITE_BARRIER_CPP(object, offset, value) | |
| 698 | 698 | #else | |
| 699 | - #define WRITE_BARRIER(object, offset, value) \ | ||
| 700 | - do { \ | ||
| 701 | - DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ | ||
| 702 | - static_assert(kTaggedCanConvertToRawObjects); \ | ||
| 703 | - CombinedWriteBarrier(object, Tagged(object)->RawField(offset), value, \ | ||
| 704 | - UPDATE_WRITE_BARRIER); \ | ||
| 699 | + #define WRITE_BARRIER(object, offset, value) \ | ||
| 700 | + do { \ | ||
| 701 | + DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ | ||
| 702 | + static_assert(kTaggedCanConvertToRawObjects); \ | ||
| 703 | + CombinedWriteBarrier(object, (object)->RawField(offset), value, \ | ||
| 704 | + UPDATE_WRITE_BARRIER); \ | ||
| 705 | 705 | } while (false) | |
| 706 | 706 | #endif | |
| 707 | 707 | ||
| 708 | 708 | #ifdef V8_DISABLE_WRITE_BARRIERS | |
| 709 | 709 | #define WEAK_WRITE_BARRIER(object, offset, value) | |
| 710 | 710 | #else | |
| 711 | - #define WEAK_WRITE_BARRIER(object, offset, value) \ | ||
| 712 | - do { \ | ||
| 713 | - DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ | ||
| 714 | - static_assert(kTaggedCanConvertToRawObjects); \ | ||
| 715 | - CombinedWriteBarrier(object, Tagged(object)->RawMaybeWeakField(offset), \ | ||
| 716 | - value, UPDATE_WRITE_BARRIER); \ | ||
| 711 | + #define WEAK_WRITE_BARRIER(object, offset, value) \ | ||
| 712 | + do { \ | ||
| 713 | + DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \ | ||
| 714 | + static_assert(kTaggedCanConvertToRawObjects); \ | ||
| 715 | + CombinedWriteBarrier(object, (object)->RawMaybeWeakField(offset), value, \ | ||
| 716 | + UPDATE_WRITE_BARRIER); \ | ||
| 717 | 717 | } while (false) | |
| 718 | 718 | #endif | |
| 719 | 719 | ||
0 commit comments