fs: add support for mode flag to specify the copy behavior · nodejs/node@ed0b62c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ed0b62c

Browse filesBrowse the repository at this point in the historyBrowse files

tetsuharuohzeki

authored and

MoLow

committed

fs: add support for mode flag to specify the copy behavior

`fs.copyFile()` supports copy-on-write operation if the underlying platform supports it by passing a mode flag. This behavior was added in a16d88d. This patch adds `mode` flag to `fs.cp()`, `fs.cpSync()`, and `fsPromises.cp()` to allow to change their behaviors to copy files. This test case is based on the test case that was introduced when we add `fs.constants.COPYFILE_FICLONE`. a16d88d. This test strategy is: - If the platform supports copy-on-write operation, check whether the destination is expected - Otherwise, the operation will fail and check whether the failure error information is expected. Fixes: #47080 PR-URL: #47084 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent d9448b8 commit ed0b62c
Copy full SHA for ed0b62c

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • fs.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/fs.md‎

Copy file name to clipboardExpand all lines: doc/api/fs.md

+1-1Lines changed: 1 addition & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -5158,7 +5158,7 @@ changes:
5158	5158	pr-url: https://github.com/nodejs/node/pull/47084
5159	5159	description: Accept an additional `mode` option to specify
5160	5160	the copy behavior as the `mode` argument of `fs.copyFile()`.
5161		- - version: v17.6.0
	5161	+ - version: v17.6.0
5162	5162	pr-url: https://github.com/nodejs/node/pull/41819
5163	5163	description: Accepts an additional `verbatimSymlinks` option to specify
5164	5164	whether to perform path resolution for symlinks.

0 commit comments

Comments

0 (0)