Commit edc1f21
crypto: initialize KeyObjectData mutex eagerly
Create the mutex before sharing key data so every copy uses one lock.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64851
Backport-PR-URL: #65087
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent be82372 commit edc1f21
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -953,10 +953,13 @@ KeyObjectData::KeyObjectData(std::nullptr_t) | |||
| 953 | 953 | ||
| 954 | 954 | KeyObjectData::KeyObjectData(ByteSource symmetric_key) | |
| 955 | 955 | : key_type_(KeyType::kKeyTypeSecret), | |
| 956 | + mutex_(std::make_shared<Mutex>()), | ||
| 956 | 957 | data_(std::make_shared<Data>(std::move(symmetric_key))) {} | |
| 957 | 958 | ||
| 958 | 959 | KeyObjectData::KeyObjectData(KeyType type, EVPKeyPointer&& pkey) | |
| 959 | - : key_type_(type), data_(std::make_shared<Data>(std::move(pkey))) {} | ||
| 960 | + : key_type_(type), | ||
| 961 | + mutex_(std::make_shared<Mutex>()), | ||
| 962 | + data_(std::make_shared<Data>(std::move(pkey))) {} | ||
| 960 | 963 | ||
| 961 | 964 | void KeyObjectData::MemoryInfo(MemoryTracker* tracker) const { | |
| 962 | 965 | if (!*this) return; | |
0 commit comments