Commit ee0a98b
src: decode native error messages as UTF-8
The native error messages can sometimes contain e.g. path content
that are typically passed in as chars with UTF8-encoded code points.
The native error throwing code previously always decode the chars
as Latin-1, which would be incorrect.
PR-URL: #55024
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e879c5e commit ee0a98b
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -119,7 +119,11 @@ void OOMErrorHandler(const char* location, const v8::OOMDetails& details); | |||
| 119 | 119 | std::string message = SPrintF(format, std::forward<Args>(args)...); \ | |
| 120 | 120 | v8::Local<v8::String> js_code = OneByteString(isolate, #code); \ | |
| 121 | 121 | v8::Local<v8::String> js_msg = \ | |
| 122 | - OneByteString(isolate, message.c_str(), message.length()); \ | ||
| 122 | + v8::String::NewFromUtf8(isolate, \ | ||
| 123 | + message.c_str(), \ | ||
| 124 | + v8::NewStringType::kNormal, \ | ||
| 125 | + message.length()) \ | ||
| 126 | + .ToLocalChecked(); \ | ||
| 123 | 127 | v8::Local<v8::Object> e = v8::Exception::type(js_msg) \ | |
| 124 | 128 | ->ToObject(isolate->GetCurrentContext()) \ | |
| 125 | 129 | .ToLocalChecked(); \ | |
0 commit comments