Commit ee4390a
committed
repl: fix tab completion of inspector module
Correctly check for the presence of the inspector module before adding
it to the builtin libs list.
PR-URL: #19505
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent cae9ff2 commit ee4390a
2 files changed
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -89,7 +89,7 @@ const builtinLibs = [ | |||
| 89 | 89 | 'stream', 'string_decoder', 'tls', 'tty', 'url', 'util', 'v8', 'vm', 'zlib' | |
| 90 | 90 | ]; | |
| 91 | 91 | ||
| 92 | - if (typeof process.binding('inspector').connect === 'function') { | ||
| 92 | + if (typeof process.binding('inspector').open === 'function') { | ||
| 93 | 93 | builtinLibs.push('inspector'); | |
| 94 | 94 | builtinLibs.sort(); | |
| 95 | 95 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,11 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + // Flags: --expose-internals | ||
| 3 | + | ||
| 4 | + require('../common'); | ||
| 5 | + const assert = require('assert'); | ||
| 6 | + const { builtinLibs } = require('internal/module'); | ||
| 7 | + | ||
| 8 | + const hasInspector = process.config.variables.v8_enable_inspector === 1; | ||
| 9 | + | ||
| 10 | + const expectedLibs = hasInspector ? 32 : 31; | ||
| 11 | + assert.strictEqual(builtinLibs.length, expectedLibs); | ||
0 commit comments