Commit ee5624b
test: adjust key sizes to support OpenSSL32
Refs: #53382
This test fails on OpenSSL32 because it complains the key
being used is too short.
Adjust the key sizes so that they will pass on OpenSSL32 in
addition to other OpenSSL3 versions.
Since the keys are not public key related I don't think the
increase in key size will be too bad in terms of performance so
I've just increased versus guarding for OpenSSL32
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54972
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 5c11a61 commit ee5624b
1 file changed
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -47,13 +47,13 @@ server.listen(0, '127.0.0.1', common.mustCall(function() { | |||
| 47 | 47 | tls.connect({ | |
| 48 | 48 | host: '127.0.0.1', | |
| 49 | 49 | port: this.address().port, | |
| 50 | - ciphers: 'AES128-SHA256', | ||
| 50 | + ciphers: 'AES256-SHA256', | ||
| 51 | 51 | rejectUnauthorized: false, | |
| 52 | 52 | maxVersion: 'TLSv1.2', | |
| 53 | 53 | }, common.mustCall(function() { | |
| 54 | 54 | const cipher = this.getCipher(); | |
| 55 | - assert.strictEqual(cipher.name, 'AES128-SHA256'); | ||
| 56 | - assert.strictEqual(cipher.standardName, 'TLS_RSA_WITH_AES_128_CBC_SHA256'); | ||
| 55 | + assert.strictEqual(cipher.name, 'AES256-SHA256'); | ||
| 56 | + assert.strictEqual(cipher.standardName, 'TLS_RSA_WITH_AES_256_CBC_SHA256'); | ||
| 57 | 57 | assert.strictEqual(cipher.version, 'TLSv1.2'); | |
| 58 | 58 | this.end(); | |
| 59 | 59 | })); | |
@@ -62,14 +62,14 @@ server.listen(0, '127.0.0.1', common.mustCall(function() { | |||
| 62 | 62 | tls.connect({ | |
| 63 | 63 | host: '127.0.0.1', | |
| 64 | 64 | port: this.address().port, | |
| 65 | - ciphers: 'ECDHE-RSA-AES128-GCM-SHA256', | ||
| 65 | + ciphers: 'ECDHE-RSA-AES256-GCM-SHA384', | ||
| 66 | 66 | rejectUnauthorized: false, | |
| 67 | 67 | maxVersion: 'TLSv1.2', | |
| 68 | 68 | }, common.mustCall(function() { | |
| 69 | 69 | const cipher = this.getCipher(); | |
| 70 | - assert.strictEqual(cipher.name, 'ECDHE-RSA-AES128-GCM-SHA256'); | ||
| 70 | + assert.strictEqual(cipher.name, 'ECDHE-RSA-AES256-GCM-SHA384'); | ||
| 71 | 71 | assert.strictEqual(cipher.standardName, | |
| 72 | - 'TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256'); | ||
| 72 | + 'TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384'); | ||
| 73 | 73 | assert.strictEqual(cipher.version, 'TLSv1.2'); | |
| 74 | 74 | this.end(); | |
| 75 | 75 | })); | |
@@ -78,19 +78,19 @@ server.listen(0, '127.0.0.1', common.mustCall(function() { | |||
| 78 | 78 | tls.createServer({ | |
| 79 | 79 | key: fixtures.readKey('agent2-key.pem'), | |
| 80 | 80 | cert: fixtures.readKey('agent2-cert.pem'), | |
| 81 | - ciphers: 'TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_CCM_8_SHA256', | ||
| 81 | + ciphers: 'TLS_CHACHA20_POLY1305_SHA256:TLS_AES_256_GCM_SHA384', | ||
| 82 | 82 | maxVersion: 'TLSv1.3', | |
| 83 | 83 | }, common.mustCall(function() { | |
| 84 | 84 | this.close(); | |
| 85 | 85 | })).listen(0, common.mustCall(function() { | |
| 86 | 86 | const client = tls.connect({ | |
| 87 | 87 | port: this.address().port, | |
| 88 | - ciphers: 'TLS_AES_128_CCM_8_SHA256', | ||
| 88 | + ciphers: 'TLS_AES_256_GCM_SHA384', | ||
| 89 | 89 | maxVersion: 'TLSv1.3', | |
| 90 | 90 | rejectUnauthorized: false | |
| 91 | 91 | }, common.mustCall(() => { | |
| 92 | 92 | const cipher = client.getCipher(); | |
| 93 | - assert.strictEqual(cipher.name, 'TLS_AES_128_CCM_8_SHA256'); | ||
| 93 | + assert.strictEqual(cipher.name, 'TLS_AES_256_GCM_SHA384'); | ||
| 94 | 94 | assert.strictEqual(cipher.standardName, cipher.name); | |
| 95 | 95 | assert.strictEqual(cipher.version, 'TLSv1.3'); | |
| 96 | 96 | client.end(); | |
0 commit comments