| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,151 @@ | |||
| 1 | + # Node Foundation CTC Meeting 2016-10-26 | ||
| 2 | + | ||
| 3 | + ## Links | ||
| 4 | + | ||
| 5 | + * **Audio Recording**: TBP | ||
| 6 | + * **GitHub Issue**: | ||
| 7 | + [#9261](https://github.com/nodejs/node/issues/9261) | ||
| 8 | + * **Minutes Google Doc**: <https://docs.google.com/document/d/1dUPFNyK8Yn1yWRAcXPY-mWM2KMWvOOB8Z5BH2s7RpJs> | ||
| 9 | + * _Previous Minutes Google Doc: <https://docs.google.com/document/d/18rnF8IfO10aQ0gRRasH3zSuv397-lm_x1fX1FSGcV7E>_ | ||
| 10 | + | ||
| 11 | + | ||
| 12 | + ## Present | ||
| 13 | + | ||
| 14 | + * Anna Henningsen @addaleax (CTC) | ||
| 15 | + * Bradley Meck @bmeck (observer/GoDaddy/TC39) | ||
| 16 | + * Ben Noordhuis @bnoordhuis (CTC) | ||
| 17 | + * Сковорода Никита Андреевич @ChALkeR (CTC) | ||
| 18 | + * Colin Ihrig @cjihrig (CTC) | ||
| 19 | + * Evan Lucas @evanlucas (CTC) | ||
| 20 | + * James M Snell @jasnell (CTC) | ||
| 21 | + * Brian White @mscdex (CTC) | ||
| 22 | + * Ali Ijaz Sheikh @ofrobots (CTC) | ||
| 23 | + * Seth Thompson @s3ththompson (observer/Google) | ||
| 24 | + * Shigeki Ohtsu @shigeki (CTC) | ||
| 25 | + * Sakthipriyan Vairamani @thefourtheye (observer) | ||
| 26 | + * Rich Trott @Trott (CTC) | ||
| 27 | + | ||
| 28 | + | ||
| 29 | + ## Standup | ||
| 30 | + | ||
| 31 | + * Anna Henningsen @addaleax (CTC) | ||
| 32 | + * Not much | ||
| 33 | + * Bradley Meck @bmeck (observer/GoDaddy/TC39) | ||
| 34 | + * Work on making inspector work w/ vm | ||
| 35 | + * Minor talks w/ modules spec authors | ||
| 36 | + * Ben Noordhuis @bnoordhuis (CTC) | ||
| 37 | + * (Nothing reported.) | ||
| 38 | + * Сковорода Никита Андреевич @ChALkeR (CTC) | ||
| 39 | + * Rebuilt a new dataset from npm packages, some further work on the tooling | ||
| 40 | + * Some issue/pr comments as usual | ||
| 41 | + * Some ecosystem security stuff | ||
| 42 | + * Colin Ihrig @cjihrig (CTC) | ||
| 43 | + * Reviewing issues and PRs, opened a few PRs, libuv 1.10.0 update | ||
| 44 | + * Evan Lucas @evanlucas (CTC) | ||
| 45 | + * Working on getting libuv to use fsevents for file watching on OS X | ||
| 46 | + * Opened small PR to fix a test that kept failing on freebsd | ||
| 47 | + * James M Snell @jasnell (CTC) | ||
| 48 | + * Getting v7.0.0 out the door | ||
| 49 | + * PRs | ||
| 50 | + * More work on HTTP/2 | ||
| 51 | + * Brian White @mscdex (CTC) | ||
| 52 | + * Continued working on string encoding/decoding performance. Starting to see even more promising results. | ||
| 53 | + * Reviewed PRs, commented on issues | ||
| 54 | + * Ali Ijaz Sheikh @ofrobots (CTC) | ||
| 55 | + * Not much | ||
| 56 | + * Seth Thompson @s3ththompson (observer/Google) | ||
| 57 | + * V8 5.5 beta shipped with async/await | ||
| 58 | + * Shigeki Ohtsu @shigeki (CTC) | ||
| 59 | + * Reviewed a few PR and made a security assessments of CVE-2016-8610 for Node-v0.10 and 0.12. | ||
| 60 | + * Sakthipriyan Vairamani @thefourtheye (observer) | ||
| 61 | + * Held an event to help people to get their first contribution into Node.js | ||
| 62 | + * Looking at V8 code base | ||
| 63 | + * Rich Trott @Trott (CTC) | ||
| 64 | + * Outreachy, Node Todo, Node Interactive prep | ||
| 65 | + * test and tools PRs | ||
| 66 | + * usual PR review/commenting | ||
| 67 | + | ||
| 68 | + | ||
| 69 | + --- | ||
| 70 | + | ||
| 71 | + | ||
| 72 | + ## Agenda | ||
| 73 | + | ||
| 74 | + | ||
| 75 | + Extracted from **ctc-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. | ||
| 76 | + | ||
| 77 | + | ||
| 78 | + ### nodejs/TSC | ||
| 79 | + | ||
| 80 | + | ||
| 81 | + * Consider folding TSC into CTC [#146](https://github.com/nodejs/TSC/issues/146) | ||
| 82 | + | ||
| 83 | + | ||
| 84 | + ### nodejs/node | ||
| 85 | + | ||
| 86 | + | ||
| 87 | + * Debugging: name every function | ||
| 88 | + [#8913]https://github.com/nodejs/node/issues/8913 | ||
| 89 | + | ||
| 90 | + | ||
| 91 | + --- | ||
| 92 | + | ||
| 93 | + | ||
| 94 | + ## Previous Meeting Review | ||
| 95 | + | ||
| 96 | + | ||
| 97 | + Extracted from **ctc-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. | ||
| 98 | + | ||
| 99 | + | ||
| 100 | + ### nodejs/node | ||
| 101 | + | ||
| 102 | + | ||
| 103 | + * doc: add ctc-review label information [#9072](https://github.com/nodejs/node/pull/9072) @Trott | ||
| 104 | + * http: improve invalid character in header error message [#9010](https://github.com/nodejs/node/pull/9010) @evanlucas | ||
| 105 | + * net: multiple listen() events fail silently [#8419](https://github.com/nodejs/node/pull/8419) @jasnell | ||
| 106 | + | ||
| 107 | + | ||
| 108 | + ### nodejs/TSC | ||
| 109 | + | ||
| 110 | + | ||
| 111 | + * Consider folding TSC into CTC [#146](https://github.com/nodejs/TSC/issues/146) @rvagg | ||
| 112 | + | ||
| 113 | + | ||
| 114 | + --- | ||
| 115 | + | ||
| 116 | + | ||
| 117 | + ## Minutes | ||
| 118 | + | ||
| 119 | + | ||
| 120 | + ### Consider folding TSC into CTC | ||
| 121 | + | ||
| 122 | + | ||
| 123 | + Rich: Defer until Rod is here and have the conversation in the issue tracker until then? | ||
| 124 | + | ||
| 125 | + | ||
| 126 | + James: Makes sense. Also, TSC call is tomorrow so it can be discussed then. | ||
| 127 | + | ||
| 128 | + | ||
| 129 | + ### Debugging: name every function | ||
| 130 | + | ||
| 131 | + | ||
| 132 | + Rich: It seemed like a good idea initially, but it is not clear if it is a good thing in all cases (some +, some -). Issue is marked as good first contribution which means lots of new contributors are coming in. | ||
| 133 | + Myles wanted a quick resolution, but it is not clear there is a quick resolution. Someone needs to sit down and come up with a list of cases where it would be beneficial | ||
| 134 | + | ||
| 135 | + | ||
| 136 | + Brian: Prototype functions? | ||
| 137 | + | ||
| 138 | + | ||
| 139 | + Rich: That is a case where it doesn't add value but doesn't hurt either. There are other cases where it does remove information. | ||
| 140 | + | ||
| 141 | + | ||
| 142 | + Sakthipriyan: One example was fs.readFileSync.. | ||
| 143 | + | ||
| 144 | + | ||
| 145 | + Brian: V8 may also be inferring names from a variable in cases when you do `let a = () => {...}`. Another case to take into consideration. | ||
| 146 | + | ||
| 147 | + | ||
| 148 | + Rich: Move back to the issue tracker; remove 'good-first-contribution' label until we have documented what should/shouldn't be done. I can work with someone, or come up with documentation. | ||
| 149 | + | ||
| 150 | + | ||
| 151 | + Floor: General agreement? Yes, general agreement. | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments