Commit ef6a210
url,tools,benchmark: replace deprecated substr()
PR-URL: #51546
Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent e016e95 commit ef6a210
5 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -212,6 +212,10 @@ module.exports = { | |||
| 212 | 212 | selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]', | |
| 213 | 213 | message: 'Use `new` keyword when throwing an `Error`.', | |
| 214 | 214 | }, | |
| 215 | + { | ||
| 216 | + selector: "CallExpression[callee.property.name='substr']", | ||
| 217 | + message: 'Use String.prototype.slice() or String.prototype.substring() instead of String.prototype.substr()', | ||
| 218 | + }, | ||
| 215 | 219 | { | |
| 216 | 220 | selector: "CallExpression[callee.name='isNaN']", | |
| 217 | 221 | message: 'Use Number.isNaN() instead of the global isNaN() function.', | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -46,7 +46,7 @@ function main({ len, n }) { | |||
| 46 | 46 | let header = `GET /hello HTTP/1.1${CRLF}Content-Type: text/plain${CRLF}`; | |
| 47 | 47 | ||
| 48 | 48 | for (let i = 0; i < len; i++) { | |
| 49 | - header += `X-Filler${i}: ${Math.random().toString(36).substr(2)}${CRLF}`; | ||
| 49 | + header += `X-Filler${i}: ${Math.random().toString(36).substring(2)}${CRLF}`; | ||
| 50 | 50 | } | |
| 51 | 51 | header += CRLF; | |
| 52 | 52 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -958,7 +958,7 @@ Url.prototype.resolveObject = function resolveObject(relative) { | |||
| 958 | 958 | srcPath.unshift(''); | |
| 959 | 959 | } | |
| 960 | 960 | ||
| 961 | - if (hasTrailingSlash && (srcPath.join('/').substr(-1) !== '/')) { | ||
| 961 | + if (hasTrailingSlash && (srcPath.join('/').slice(-1) !== '/')) { | ||
| 962 | 962 | srcPath.push(''); | |
| 963 | 963 | } | |
| 964 | 964 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -394,8 +394,8 @@ function versionSort(a, b) { | |||
| 394 | 394 | b = minVersion(b).trim(); | |
| 395 | 395 | let i = 0; // Common prefix length. | |
| 396 | 396 | while (i < a.length && i < b.length && a[i] === b[i]) i++; | |
| 397 | - a = a.substr(i); | ||
| 398 | - b = b.substr(i); | ||
| 397 | + a = a.substring(i); | ||
| 398 | + b = b.substring(i); | ||
| 399 | 399 | return +b.match(numberRe)[0] - +a.match(numberRe)[0]; | |
| 400 | 400 | } | |
| 401 | 401 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -320,8 +320,8 @@ function parseSignature(text, sig) { | |||
| 320 | 320 | ||
| 321 | 321 | const eq = sigParam.indexOf('='); | |
| 322 | 322 | if (eq !== -1) { | |
| 323 | - defaultValue = sigParam.substr(eq + 1); | ||
| 324 | - sigParam = sigParam.substr(0, eq); | ||
| 323 | + defaultValue = sigParam.substring(eq + 1); | ||
| 324 | + sigParam = sigParam.substring(0, eq); | ||
| 325 | 325 | } | |
| 326 | 326 | ||
| 327 | 327 | // At this point, the name should match. If it doesn't find one that does. | |
0 commit comments