Commit efd6630
test: fix flakiness in worker*.test-free-called
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.
Fixes: #51003
PR-URL: #51013
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent a80f660 commit efd6630
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,12 +6,14 @@ const { Worker } = require('worker_threads'); | |||
| 6 | 6 | const binding = path.resolve(__dirname, `./build/${common.buildType}/binding`); | |
| 7 | 7 | const { getFreeCallCount } = require(binding); | |
| 8 | 8 | ||
| 9 | + // getFreeCallCount initial value is 0 | ||
| 10 | + assert.strictEqual(getFreeCallCount(), 0); | ||
| 11 | + | ||
| 9 | 12 | // Test that buffers allocated with a free callback through our APIs are | |
| 10 | 13 | // released when a Worker owning it exits. | |
| 11 | 14 | ||
| 12 | 15 | const w = new Worker(`require(${JSON.stringify(binding)})`, { eval: true }); | |
| 13 | 16 | ||
| 14 | - assert.strictEqual(getFreeCallCount(), 0); | ||
| 15 | 17 | w.on('exit', common.mustCall(() => { | |
| 16 | 18 | assert.strictEqual(getFreeCallCount(), 1); | |
| 17 | 19 | })); | |
0 commit comments