Commit efe71e9
build: Don't set -fno-threadsafe-statics on macOS
This flag is not set on other platforms so it can produce inconsistent
behaviour across platforms. For example, if you build an async node
add-on which uses statics you can get race conditions due to static
not supporting threads if the node add-on inherits from the Node
common.gypi config. It is not disabled on other platforms such as
Linux, it is not disabled by default in Xcode or clang.
This setting has been there since the initial commit that introduces
`common.gypi` and thus has been there since the start, it doesn't seem
to be have added for any particular reason other than to potentially
match the Xcode defaults at the time.
PR-URL: #22198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 887c43f commit efe71e9
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -447,7 +447,6 @@ | |||
| 447 | 447 | 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions | |
| 448 | 448 | 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti | |
| 449 | 449 | 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings | |
| 450 | - 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics | ||
| 451 | 450 | 'PREBINDING': 'NO', # No -Wl,-prebind | |
| 452 | 451 | 'MACOSX_DEPLOYMENT_TARGET': '10.7', # -mmacosx-version-min=10.7 | |
| 453 | 452 | 'USE_HEADERMAP': 'NO', | |
0 commit comments