Commit f0202a7
test: fix test/pummel/test-fs-largefile.js
test-fs-largefile.js calls `fs.close()` without a callback which results
in an error as of Node.js 10.0.0. Add a `common.mustCall()` callback so
the test passes again.
PR-URL: #25372
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent f58b530 commit f0202a7
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,7 +20,7 @@ | |||
| 20 | 20 | // USE OR OTHER DEALINGS IN THE SOFTWARE. | |
| 21 | 21 | ||
| 22 | 22 | 'use strict'; | |
| 23 | - require('../common'); | ||
| 23 | + const common = require('../common'); | ||
| 24 | 24 | ||
| 25 | 25 | const assert = require('assert'); | |
| 26 | 26 | const fs = require('fs'); | |
@@ -46,7 +46,7 @@ assert.strictEqual(readBuf[0], 0); | |||
| 46 | 46 | ||
| 47 | 47 | // Verify that floating point positions do not throw. | |
| 48 | 48 | fs.writeSync(fd, writeBuf, 0, writeBuf.length, 42.000001); | |
| 49 | - fs.close(fd); | ||
| 49 | + fs.close(fd, common.mustCall()); | ||
| 50 | 50 | ||
| 51 | 51 | // Normally, we don't clean up tmp files at the end of a test, but we'll make an | |
| 52 | 52 | // exception for a 5 GB file. | |
0 commit comments