FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove common.inspect() · nodejs/node@f0f8afd · GitHub

/ node Public

Commit f0f8afd

Browse files
Trott
authored and
jasnell
committed
test: remove common.inspect()
common.inspect() is just util.inspect(). common copies every property from util but this is the only one that gets used and it only gets used in three places. Well, four, but the fourth is removed in a pending PR. This commit removes it. Subsequently, the "copy util to common" part of `common` can be removed altogether. PR-URL: #3257 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
1 parent 5ca4f6f commit f0f8afd

3 files changed

Lines changed: 9 additions & 45 deletions

File tree

‎test/parallel/test-fs-realpath.js‎

Lines changed: 9 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,9 @@ function test_simple_relative_symlink(callback) {
9393
unlink.push(t[0]);
9494
});
9595
var result = fs.realpathSync(entry);
96-
assert.equal(result, path.resolve(expected),
97-
'got ' + common.inspect(result) + ' expected ' +
98-
common.inspect(expected));
96+
assert.equal(result, path.resolve(expected));
9997
asynctest(fs.realpath, [entry], callback, function(err, result) {
100-
assert.equal(result, path.resolve(expected),
101-
'got ' +
102-
common.inspect(result) +
103-
' expected ' +
104-
common.inspect(expected));
98+
assert.equal(result, path.resolve(expected));
10599
});
106100
}
107101

@@ -125,17 +119,9 @@ function test_simple_absolute_symlink(callback) {
125119
unlink.push(t[0]);
126120
});
127121
var result = fs.realpathSync(entry);
128-
assert.equal(result, path.resolve(expected),
129-
'got ' +
130-
common.inspect(result) +
131-
' expected ' +
132-
common.inspect(expected));
122+
assert.equal(result, path.resolve(expected));
133123
asynctest(fs.realpath, [entry], callback, function(err, result) {
134-
assert.equal(result, path.resolve(expected),
135-
'got ' +
136-
common.inspect(result) +
137-
' expected ' +
138-
common.inspect(expected));
124+
assert.equal(result, path.resolve(expected));
139125
});
140126
}
141127

@@ -163,11 +149,7 @@ function test_deep_relative_file_symlink(callback) {
163149

164150
assert.equal(fs.realpathSync(entry), path.resolve(expected));
165151
asynctest(fs.realpath, [entry], callback, function(err, result) {
166-
assert.equal(result, path.resolve(expected),
167-
'got ' +
168-
common.inspect(result) +
169-
' expected ' +
170-
common.inspect(path.resolve(expected)));
152+
assert.equal(result, path.resolve(expected));
171153
});
172154
}
173155

@@ -195,11 +177,7 @@ function test_deep_relative_dir_symlink(callback) {
195177
assert.equal(fs.realpathSync(entry), path.resolve(expected));
196178

197179
asynctest(fs.realpath, [entry], callback, function(err, result) {
198-
assert.equal(result, path.resolve(expected),
199-
'got ' +
200-
common.inspect(result) +
201-
' expected ' +
202-
common.inspect(path.resolve(expected)));
180+
assert.equal(result, path.resolve(expected));
203181
});
204182
}
205183

@@ -280,11 +258,7 @@ function test_relative_input_cwd(callback) {
280258
assert.equal(fs.realpathSync(entry), path.resolve(expected));
281259
asynctest(fs.realpath, [entry], callback, function(err, result) {
282260
process.chdir(origcwd);
283-
assert.equal(result, path.resolve(expected),
284-
'got ' +
285-
common.inspect(result) +
286-
' expected ' +
287-
common.inspect(path.resolve(expected)));
261+
assert.equal(result, path.resolve(expected));
288262
return true;
289263
});
290264
}
@@ -336,11 +310,7 @@ function test_deep_symlink_mix(callback) {
336310
var expected = tmpAbsDir + '/cycles/root.js';
337311
assert.equal(fs.realpathSync(entry), path.resolve(expected));
338312
asynctest(fs.realpath, [entry], callback, function(err, result) {
339-
assert.equal(result, path.resolve(expected),
340-
'got ' +
341-
common.inspect(result) +
342-
' expected ' +
343-
common.inspect(path.resolve(expected)));
313+
assert.equal(result, path.resolve(expected));
344314
return true;
345315
});
346316
}
@@ -355,11 +325,7 @@ function test_non_symlinks(callback) {
355325
assert.equal(fs.realpathSync(entry), path.resolve(expected));
356326
asynctest(fs.realpath, [entry], callback, function(err, result) {
357327
process.chdir(origcwd);
358-
assert.equal(result, path.resolve(expected),
359-
'got ' +
360-
common.inspect(result) +
361-
' expected ' +
362-
common.inspect(path.resolve(expected)));
328+
assert.equal(result, path.resolve(expected));
363329
return true;
364330
});
365331
}

‎test/parallel/test-memory-usage.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@ var common = require('../common');
33
var assert = require('assert');
44

55
var r = process.memoryUsage();
6-
console.log(common.inspect(r));
76
assert.equal(true, r['rss'] > 0);

‎test/sequential/test-memory-usage-emfile.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@ while (files.length < 256)
1010
files.push(fs.openSync(__filename, 'r'));
1111

1212
var r = process.memoryUsage();
13-
console.log(common.inspect(r));
1413
assert.equal(true, r['rss'] > 0);

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL