Commit f10d9ad
stream: treat null asyncIterator as undefined
According to the spec, getIterator should normalize incoming method to
undefined if it is either undefined or null. This PR enforces that spec
compliance with passed WPT.
PR-URL: #55119
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>1 parent 81bcec0 commit f10d9ad
2 files changed
Lines changed: 2 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -230,11 +230,12 @@ function createAsyncFromSyncIterator(syncIteratorRecord) { | |||
| 230 | 230 | return { iterator: asyncIterator, nextMethod, done: false }; | |
| 231 | 231 | } | |
| 232 | 232 | ||
| 233 | + // Refs: https://tc39.es/ecma262/#sec-getiterator | ||
| 233 | 234 | function getIterator(obj, kind = 'sync', method) { | |
| 234 | 235 | if (method === undefined) { | |
| 235 | 236 | if (kind === 'async') { | |
| 236 | 237 | method = obj[SymbolAsyncIterator]; | |
| 237 | - if (method === undefined) { | ||
| 238 | + if (method == null) { | ||
| 238 | 239 | const syncMethod = obj[SymbolIterator]; | |
| 239 | 240 | ||
| 240 | 241 | if (syncMethod === undefined) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,13 +16,6 @@ | |||
| 16 | 16 | "readable-streams/cross-realm-crash.window.js": { | |
| 17 | 17 | "skip": "Browser-specific test" | |
| 18 | 18 | }, | |
| 19 | - "readable-streams/from.any.js": { | ||
| 20 | - "fail": { | ||
| 21 | - "expected": [ | ||
| 22 | - "ReadableStream.from ignores a null @@asyncIterator" | ||
| 23 | - ] | ||
| 24 | - } | ||
| 25 | - }, | ||
| 26 | 19 | "readable-streams/owning-type-message-port.any.js": { | |
| 27 | 20 | "fail": { | |
| 28 | 21 | "note": "Readable streams with type owning are not yet supported", | |
0 commit comments