src: fix alloc-dealloc-mismatch in node_snapshotable.h · nodejs/node@f1381f7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f1381f7

Browse filesBrowse the repository at this point in the historyBrowse files

RaisinTen

authored and

targos

committed

src: fix alloc-dealloc-mismatch in node_snapshotable.h

Fixes: #37442 PR-URL: #37443 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

1 parent b38404e commit f1381f7
Copy full SHA for f1381f7

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_snapshotable.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_snapshotable.h‎

Copy file name to clipboardExpand all lines: src/node_snapshotable.h

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -48,20 +48,20 @@ struct InternalFieldInfo {
48	48
49	49	static InternalFieldInfo* New(EmbedderObjectType type, size_t length) {
50	50	InternalFieldInfo* result =
51		- reinterpret_cast<InternalFieldInfo*>(::operator new(length));
	51	+ reinterpret_cast<InternalFieldInfo*>(::operator new[](length));
52	52	result->type = type;
53	53	result->length = length;
54	54	return result;
55	55	}
56	56
57	57	InternalFieldInfo* Copy() const {
58	58	InternalFieldInfo* result =
59		- reinterpret_cast<InternalFieldInfo*>(::operator new(length));
	59	+ reinterpret_cast<InternalFieldInfo*>(::operator new[](length));
60	60	memcpy(result, this, length);
61	61	return result;
62	62	}
63	63
64		- void Delete() { ::operator delete(this); }
	64	+ void Delete() { ::operator delete[](this); }
65	65	};
66	66
67	67	// An interface for snapshotable native objects to inherit from.

0 commit comments

Comments

0 (0)