Commit f1e7648
test: validate common property usage
`common` contains multiple 'check'(boolean) properties that will be
false if mistyped and may lead to errors.
This makes sure that the used property exists in the `common`.
PR-URL: #31933
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent ab8f060 commit f1e7648
1 file changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -672,7 +672,7 @@ function invalidArgTypeHelper(input) { | |||
| 672 | 672 | return ` Received type ${typeof input} (${inspected})`; | |
| 673 | 673 | } | |
| 674 | 674 | ||
| 675 | - module.exports = { | ||
| 675 | + const common = { | ||
| 676 | 676 | allowGlobals, | |
| 677 | 677 | buildType, | |
| 678 | 678 | canCreateSymLink, | |
@@ -815,3 +815,12 @@ module.exports = { | |||
| 815 | 815 | } | |
| 816 | 816 | ||
| 817 | 817 | }; | |
| 818 | + | ||
| 819 | + const validProperties = new Set(Object.keys(common)); | ||
| 820 | + module.exports = new Proxy(common, { | ||
| 821 | + get(obj, prop) { | ||
| 822 | + if (!validProperties.has(prop)) | ||
| 823 | + throw new Error(`Using invalid common property: '${prop}'`); | ||
| 824 | + return obj[prop]; | ||
| 825 | + } | ||
| 826 | + }); | ||
0 commit comments