Commit f21cf45
committed
src: ignore GCC -Wcast-function-type for v8.h
Currently, the following warnings are emitted during compilation:
In file included from ../src/string_bytes.h:29,
from ../src/string_bytes.cc:22:
../deps/v8/include/v8.h:
In instantiation of ‘void v8::PersistentBase<T>::SetWeak(
P*,typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType)
[with P = node::BaseObject;
T = v8::Object;
typename v8::WeakCallbackInfo<P>::Callback =
void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’:
../src/base_object-inl.h:135:42: required from here
../deps/v8/include/v8.h:10732:16: warning:
cast between incompatible function types from
‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka
‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to
‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’}
[-Wcast-function-type]
10732 | reinterpret_cast<Callback>(callback), type);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
And the same from test/cctest/test_aliased_buffer.cc
We have an open pull request against v8 for this:
https://chromium-review.googlesource.com/c/v8/v8/+/2080361
PR-URL: #32679
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 55b4d03 commit f21cf45
2 files changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,7 +26,14 @@ | |||
| 26 | 26 | ||
| 27 | 27 | // Decodes a v8::Local<v8::String> or Buffer to a raw char* | |
| 28 | 28 | ||
| 29 | + #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 30 | + #pragma GCC diagnostic push | ||
| 31 | + #pragma GCC diagnostic ignored "-Wcast-function-type" | ||
| 32 | + #endif | ||
| 29 | 33 | #include "v8.h" | |
| 34 | + #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 35 | + #pragma GCC diagnostic pop | ||
| 36 | + #endif | ||
| 30 | 37 | #include "env-inl.h" | |
| 31 | 38 | ||
| 32 | 39 | #include <string> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,4 +1,11 @@ | |||
| 1 | + #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 2 | + #pragma GCC diagnostic push | ||
| 3 | + #pragma GCC diagnostic ignored "-Wcast-function-type" | ||
| 4 | + #endif | ||
| 1 | 5 | #include "v8.h" | |
| 6 | + #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 7 | + #pragma GCC diagnostic pop | ||
| 8 | + #endif | ||
| 2 | 9 | #include "aliased_buffer.h" | |
| 3 | 10 | #include "node_test_fixture.h" | |
| 4 | 11 | ||
0 commit comments