Commit f225459
test: improve test-npm-install
Make npm install a dependency that is defined as a relative path, so it
avoids any network interaction.
PR-URL: #5613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>1 parent cceae5a commit f225459
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -22,7 +22,11 @@ const args = [ | |||
| 22 | 22 | 'install' | |
| 23 | 23 | ]; | |
| 24 | 24 | ||
| 25 | - const pkgContent = '{}'; | ||
| 25 | + const pkgContent = JSON.stringify({ | ||
| 26 | + dependencies: { | ||
| 27 | + 'package-name': common.fixturesDir + '/packages/main' | ||
| 28 | + } | ||
| 29 | + }); | ||
| 26 | 30 | ||
| 27 | 31 | const pkgPath = path.join(common.tmpDir, 'package.json'); | |
| 28 | 32 | ||
@@ -35,6 +39,9 @@ const proc = spawn(process.execPath, args, { | |||
| 35 | 39 | function handleExit(code, signalCode) { | |
| 36 | 40 | assert.equal(code, 0, 'npm install should run without an error'); | |
| 37 | 41 | assert.ok(signalCode === null, 'signalCode should be null'); | |
| 42 | + assert.doesNotThrow(function() { | ||
| 43 | + fs.accessSync(common.tmpDir + '/node_modules/package-name'); | ||
| 44 | + }); | ||
| 38 | 45 | } | |
| 39 | 46 | ||
| 40 | 47 | proc.on('exit', common.mustCall(handleExit)); | |
0 commit comments