Commit f24aa7e
test: improve error messages in test-npm-install
PR-URL: #11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>1 parent 1db89d4 commit f24aa7e
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -48,8 +48,8 @@ const proc = spawn(process.execPath, args, { | |||
| 48 | 48 | }); | |
| 49 | 49 | ||
| 50 | 50 | function handleExit(code, signalCode) { | |
| 51 | - assert.equal(code, 0, 'npm install should run without an error'); | ||
| 52 | - assert.ok(signalCode === null, 'signalCode should be null'); | ||
| 51 | + assert.strictEqual(code, 0, `npm install got error code ${code}`); | ||
| 52 | + assert.strictEqual(signalCode, null, `unexpected signal: ${signalCode}`); | ||
| 53 | 53 | assert.doesNotThrow(function() { | |
| 54 | 54 | fs.accessSync(installDir + '/node_modules/package-name'); | |
| 55 | 55 | }); | |
0 commit comments