Commit f24caef
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
Backport-PR-URL: #28955
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>1 parent 94c8d06 commit f24caef
2 files changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.7', | ||
| 41 | + 'v8_embedder_string': '-node.8', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -282,6 +282,10 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index, | |||
| 282 | 282 | ||
| 283 | 283 | } // namespace | |
| 284 | 284 | ||
| 285 | + #ifdef _MSC_VER | ||
| 286 | + #pragma optimize( "", off ) | ||
| 287 | + #endif | ||
| 288 | + | ||
| 285 | 289 | // static | |
| 286 | 290 | void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) { | |
| 287 | 291 | Builtins* builtins = isolate->builtins(); | |
@@ -359,5 +363,10 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) { | |||
| 359 | 363 | builtins->MarkInitialized(); | |
| 360 | 364 | } | |
| 361 | 365 | ||
| 366 | + #ifdef _MSC_VER | ||
| 367 | + #pragma optimize( "", on ) | ||
| 368 | + #endif | ||
| 369 | + | ||
| 370 | + | ||
| 362 | 371 | } // namespace internal | |
| 363 | 372 | } // namespace v8 | |
0 commit comments