Commit f2b01cb
child_process: defer error to next tick
PR-URL: #4670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>1 parent 5ea25d2 commit f2b01cb
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -599,7 +599,7 @@ function setupChannel(target, channel) { | |||
| 599 | 599 | if (typeof callback === 'function') { | |
| 600 | 600 | process.nextTick(callback, ex); | |
| 601 | 601 | } else { | |
| 602 | - this.emit('error', ex); // FIXME(bnoordhuis) Defer to next tick. | ||
| 602 | + process.nextTick(() => this.emit('error', ex)); | ||
| 603 | 603 | } | |
| 604 | 604 | return false; | |
| 605 | 605 | }; | |
@@ -713,7 +713,7 @@ function setupChannel(target, channel) { | |||
| 713 | 713 | if (typeof callback === 'function') { | |
| 714 | 714 | process.nextTick(callback, ex); | |
| 715 | 715 | } else { | |
| 716 | - this.emit('error', ex); // FIXME(bnoordhuis) Defer to next tick. | ||
| 716 | + process.nextTick(() => this.emit('error', ex)); | ||
| 717 | 717 | } | |
| 718 | 718 | } | |
| 719 | 719 | } | |
0 commit comments