test: define NAPI_VERSION before including node_api.h · nodejs/node@f2ce8e0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f2ce8e0

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

ruyadorno

committed

test: define NAPI_VERSION before including node_api.h

Include node.h first to define NAPI_VERSION that node binary is built with. The node.h should also be included first in embedder's use case since it is the primary header file. PR-URL: #48376 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent 13ac0a5 commit f2ce8e0
Copy full SHA for f2ce8e0

1 file changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/cctest
  • test_linked_binding.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/cctest/test_linked_binding.cc‎

Copy file name to clipboardExpand all lines: test/cctest/test_linked_binding.cc

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,3 +1,7 @@
	1	+ // Include node.h first to define NAPI_VERSION built with the
	2	+ // binary.
	3	+ // The node.h should also be included first in embedder's use case.
	4	+ #include "node.h"
1	5	#include "node_api.h"
2	6	#include "node_test_fixture.h"
3	7

0 commit comments

Comments

0 (0)