doc: document breaking change in `http.IncomingMessage` `'close'` event · nodejs/node@f2dc7c8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f2dc7c8

Browse filesBrowse the repository at this point in the historyBrowse files

ShogunPanda

authored and

juanarbol

committed

doc: document breaking change in http.IncomingMessage 'close' event

PR-URL: #42521 Fixes: #38924 Refs: #33035 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent f83fc62 commit f2dc7c8
Copy full SHA for f2dc7c8

2 files changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc
  • api
    • http.md
  • changelogs
    • CHANGELOG_V16.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/http.md‎

Copy file name to clipboardExpand all lines: doc/api/http.md

+6-1Lines changed: 6 additions & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -2102,9 +2102,14 @@ Emitted when the request has been aborted.
2102	2102
2103	2103	<!-- YAML
2104	2104	added: v0.4.2
	2105	+ changes:
	2106	+ - version: v16.0.0
	2107	+ pr-url: https://github.com/nodejs/node/pull/33035
	2108	+ description: The close event is now emitted when the request has been completed and not when the
	2109	+ underlying socket is closed.
2105	2110	-->
2106	2111
2107		- Indicates that the underlying connection was closed.
	2112	+ Emitted when the request has been completed.
2108	2113
2109	2114	### `message.aborted`
2110	2115

Collapse file

‎doc/changelogs/CHANGELOG_V16.md‎

Copy file name to clipboardExpand all lines: doc/changelogs/CHANGELOG_V16.md

+1Lines changed: 1 addition & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -2745,6 +2745,7 @@ Contributed by Michaël Zasso - [#37587](https://github.com/nodejs/node/pull/375
2745	2745	* **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277](https://github.com/nodejs/node/pull/38277)
2746	2746	* **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254](https://github.com/nodejs/node/pull/38254)
2747	2747	* **(SEMVER-MINOR)** **http**: add http.ClientRequest.getRawHeaderNames() (simov) [#37660](https://github.com/nodejs/node/pull/37660)
	2748	+ * **(SEMVER-MAJOR)** **http**: use `autoDestroy: true` in incoming message (Daniele Belardi) [#33035](https://github.com/nodejs/node/pull/33035)
2748	2749	* **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478](https://github.com/nodejs/node/pull/36478)
2749	2750	* **(SEMVER-MINOR)** **module**: add support for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246](https://github.com/nodejs/node/pull/37246)
2750	2751	* **(SEMVER-MINOR)** **perf\_hooks**: add histogram option to timerify (James M Snell) [#37475](https://github.com/nodejs/node/pull/37475)

0 commit comments

Comments

0 (0)