Commit f317bba
tls: permit null as a cipher value
Allow null along with undefined for cipher value.
Fixes: #36292
PR-URL: #36318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 29b5236 commit f317bba
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -263,7 +263,7 @@ exports.createSecureContext = function createSecureContext(options) { | |||
| 263 | 263 | } | |
| 264 | 264 | } | |
| 265 | 265 | ||
| 266 | - if (ciphers !== undefined) | ||
| 266 | + if (ciphers != null) | ||
| 267 | 267 | validateString(ciphers, 'options.ciphers'); | |
| 268 | 268 | ||
| 269 | 269 | // Work around an OpenSSL API quirk. cipherList is for TLSv1.2 and below, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -104,3 +104,7 @@ test('AES256-SHA', ':', U, U, 'ERR_INVALID_ARG_VALUE'); | |||
| 104 | 104 | // Using '' is synonymous for "use default ciphers" | |
| 105 | 105 | test('TLS_AES_256_GCM_SHA384', '', 'TLS_AES_256_GCM_SHA384'); | |
| 106 | 106 | test('', 'TLS_AES_256_GCM_SHA384', 'TLS_AES_256_GCM_SHA384'); | |
| 107 | + | ||
| 108 | + // Using null should be treated the same as undefined. | ||
| 109 | + test(null, 'AES256-SHA', 'AES256-SHA'); | ||
| 110 | + test('AES256-SHA', null, 'AES256-SHA'); | ||
0 commit comments