Commit f366208
committed
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC.
PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #51362
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 5cddd3b commit f366208
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ | |||
| 37 | 37 | ||
| 38 | 38 | # Reset this number to 0 on major V8 upgrades. | |
| 39 | 39 | # Increment by one for each non-official patch applied to deps/v8. | |
| 40 | - 'v8_embedder_string': '-node.0', | ||
| 40 | + 'v8_embedder_string': '-node.1', | ||
| 41 | 41 | ||
| 42 | 42 | ##### V8 defaults for Node.js ##### | |
| 43 | 43 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -368,9 +368,9 @@ bool is_inbounds(float_t v) { | |||
| 368 | 368 | // Setup for Windows shared library export. | |
| 369 | 369 | #define V8_EXPORT_ENUM | |
| 370 | 370 | #ifdef BUILDING_V8_SHARED_PRIVATE | |
| 371 | - #define V8_EXPORT_PRIVATE __declspec(dllexport) | ||
| 371 | + #define V8_EXPORT_PRIVATE | ||
| 372 | 372 | #elif USING_V8_SHARED_PRIVATE | |
| 373 | - #define V8_EXPORT_PRIVATE __declspec(dllimport) | ||
| 373 | + #define V8_EXPORT_PRIVATE | ||
| 374 | 374 | #else | |
| 375 | 375 | #define V8_EXPORT_PRIVATE | |
| 376 | 376 | #endif // BUILDING_V8_SHARED | |
@@ -380,8 +380,8 @@ bool is_inbounds(float_t v) { | |||
| 380 | 380 | // Setup for Linux shared library export. | |
| 381 | 381 | #if V8_HAS_ATTRIBUTE_VISIBILITY | |
| 382 | 382 | #ifdef BUILDING_V8_SHARED_PRIVATE | |
| 383 | - #define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) | ||
| 384 | - #define V8_EXPORT_ENUM V8_EXPORT_PRIVATE | ||
| 383 | + #define V8_EXPORT_PRIVATE | ||
| 384 | + #define V8_EXPORT_ENUM | ||
| 385 | 385 | #else | |
| 386 | 386 | #define V8_EXPORT_PRIVATE | |
| 387 | 387 | #define V8_EXPORT_ENUM | |
0 commit comments