Commit f36bee4
util: avoid run debug when enabled is false
it can improve performace 700x faster
PR-URL: #57494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>1 parent 87e0dda commit f36bee4
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -62,7 +62,7 @@ function lazyUtilColors() { | |||
| 62 | 62 | return utilColors; | |
| 63 | 63 | } | |
| 64 | 64 | ||
| 65 | - function debuglogImpl(enabled, set, args) { | ||
| 65 | + function debuglogImpl(enabled, set) { | ||
| 66 | 66 | if (debugImpls[set] === undefined) { | |
| 67 | 67 | if (enabled) { | |
| 68 | 68 | const pid = process.pid; | |
@@ -109,6 +109,8 @@ function debuglog(set, cb) { | |||
| 109 | 109 | return enabled; | |
| 110 | 110 | }; | |
| 111 | 111 | const logger = (...args) => { | |
| 112 | + // Improve performance when debug is disabled, avoid calling `new SafeArrayIterator(args)` | ||
| 113 | + if (enabled === false) return; | ||
| 112 | 114 | switch (args.length) { | |
| 113 | 115 | case 1: return debug(args[0]); | |
| 114 | 116 | case 2: return debug(args[0], args[1]); | |
0 commit comments