Commit f37450f
committed
dns: use length for building TXT string
Rely on the length reported by C-Ares rather than `\0`-termination
for creating the JS string for a dns TXT response.
Fixes: #30688
PR-URL: #30690
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 099d3fd commit f37450f
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -904,7 +904,8 @@ int ParseTxtReply(Environment* env, | |||
| 904 | 904 | uint32_t i = 0, j; | |
| 905 | 905 | uint32_t offset = ret->Length(); | |
| 906 | 906 | for (j = 0; current != nullptr; current = current->next) { | |
| 907 | - Local<String> txt = OneByteString(env->isolate(), current->txt); | ||
| 907 | + Local<String> txt = | ||
| 908 | + OneByteString(env->isolate(), current->txt, current->length); | ||
| 908 | 909 | ||
| 909 | 910 | // New record found - write out the current chunk | |
| 910 | 911 | if (current->record_start) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,7 @@ const answers = [ | |||
| 11 | 11 | { type: 'AAAA', address: '::42', ttl: 123 }, | |
| 12 | 12 | { type: 'MX', priority: 42, exchange: 'foobar.com', ttl: 124 }, | |
| 13 | 13 | { type: 'NS', value: 'foobar.org', ttl: 457 }, | |
| 14 | - { type: 'TXT', entries: [ 'v=spf1 ~all', 'xyz' ] }, | ||
| 14 | + { type: 'TXT', entries: [ 'v=spf1 ~all', 'xyz\0foo' ] }, | ||
| 15 | 15 | { type: 'PTR', value: 'baz.org', ttl: 987 }, | |
| 16 | 16 | { | |
| 17 | 17 | type: 'SOA', | |
0 commit comments