build: use `$(BUILDTYPE)` when cleaning coverage files · nodejs/node@f37633e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f37633e

Browse filesBrowse the repository at this point in the historyBrowse files

avivkeller

authored and

aduh95

committed

build: use $(BUILDTYPE) when cleaning coverage files

PR-URL: #57995 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent d9700fe commit f37633e
Copy full SHA for f37633e

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Makefile

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -238,7 +238,7 @@ coverage-clean: ## Remove coverage artifacts.
238	238	$(RM) -r node_modules
239	239	$(RM) -r gcovr
240	240	$(RM) -r coverage/tmp
241		- @if [ -d "out/Release/obj.target" ]; then \
	241	+ @if [ -d "out/$(BUILDTYPE)/obj.target" ]; then \
242	242	$(FIND) out/$(BUILDTYPE)/obj.target \( -name "*.gcda" -o -name "*.gcno" \) \
243	243	-type f | xargs $(RM); \
244	244	fi
@@ -265,7 +265,7 @@ coverage-build-js: ## Build JavaScript coverage files.
265	265
266	266	.PHONY: coverage-test
267	267	coverage-test: coverage-build ## Run the tests and generate a coverage report.
268		- @if [ -d "out/Release/obj.target" ]; then \
	268	+ @if [ -d "out/$(BUILDTYPE)/obj.target" ]; then \
269	269	$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f | xargs $(RM); \
270	270	fi
271	271	-NODE_V8_COVERAGE=coverage/tmp \

0 commit comments

Comments

0 (0)