Commit f3ab106
buffer: remove obsolete NaN check
These two NaN entries are not necessary and we can safely remove them.
PR-URL: #18744
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent ed55374 commit f3ab106
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -377,10 +377,7 @@ function fromArrayBuffer(obj, byteOffset, length) { | |||
| 377 | 377 | } else { | |
| 378 | 378 | // convert length to non-negative integer | |
| 379 | 379 | length = +length; | |
| 380 | - // Check for NaN | ||
| 381 | - if (length !== length) { | ||
| 382 | - length = 0; | ||
| 383 | - } else if (length > 0) { | ||
| 380 | + if (length > 0) { | ||
| 384 | 381 | if (length > maxLength) | |
| 385 | 382 | throw new errors.RangeError('ERR_BUFFER_OUT_OF_BOUNDS', 'length'); | |
| 386 | 383 | } else { | |
@@ -403,7 +400,7 @@ function fromObject(obj) { | |||
| 403 | 400 | } | |
| 404 | 401 | ||
| 405 | 402 | if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) { | |
| 406 | - if (typeof obj.length !== 'number' || obj.length !== obj.length) { | ||
| 403 | + if (typeof obj.length !== 'number') { | ||
| 407 | 404 | return new FastBuffer(); | |
| 408 | 405 | } | |
| 409 | 406 | return fromArrayLike(obj); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -148,3 +148,6 @@ b.writeDoubleBE(11.11, 0, true); | |||
| 148 | 148 | message: '"length" is outside of buffer bounds' | |
| 149 | 149 | }); | |
| 150 | 150 | } | |
| 151 | + | ||
| 152 | + // Test an array like entry with the length set to NaN. | ||
| 153 | + assert.deepStrictEqual(Buffer.from({ length: NaN }), Buffer.alloc(0)); | ||
0 commit comments