buffer: cache Environment::GetCurrent to avoid repeated calls · nodejs/node@f444c8e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 639
• Pull requests 566
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f444c8e

Browse filesBrowse the repository at this point in the historyBrowse files

mertcanaltin

committed

buffer: cache Environment::GetCurrent to avoid repeated calls

1 parent 049664b commit f444c8e
Copy full SHA for f444c8e

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_buffer.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_buffer.cc‎

Copy file name to clipboardExpand all lines: src/node_buffer.cc

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1061,8 +1061,9 @@ void IndexOfBuffer(const FunctionCallbackInfo<Value>& args) {
1061	1061
1062	1062	enum encoding enc = static_cast<enum encoding>(args[3].As<Int32>()->Value());
1063	1063
1064		- THROW_AND_RETURN_UNLESS_BUFFER(Environment::GetCurrent(args), args[0]);
1065		- THROW_AND_RETURN_UNLESS_BUFFER(Environment::GetCurrent(args), args[1]);
	1064	+ Environment* env = Environment::GetCurrent(args);
	1065	+ THROW_AND_RETURN_UNLESS_BUFFER(env, args[0]);
	1066	+ THROW_AND_RETURN_UNLESS_BUFFER(env, args[1]);
1066	1067	ArrayBufferViewContents<char> haystack_contents(args[0]);
1067	1068	ArrayBufferViewContents<char> needle_contents(args[1]);
1068	1069	int64_t offset_i64 = args[2].As<Integer>()->Value();

0 commit comments

Comments

0 (0)