Commit f44c0a5
build: Don't regenerate node symlink
The node -> out/*/node symlink is getting recreated in parallel with
other targets in the makefile which require it (e.g. test-ci) and
this seems to be causing a race condition which is showing up on AIX
Fixes: #9825
PR-URL: #9827
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 214b514 commit f44c0a5
1 file changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -64,13 +64,18 @@ endif | |||
| 64 | 64 | # to check for changes. | |
| 65 | 65 | .PHONY: $(NODE_EXE) $(NODE_G_EXE) | |
| 66 | 66 | ||
| 67 | + # The -r/-L check stops it recreating the link if it is already in place, | ||
| 68 | + # otherwise $(NODE_EXE) being a .PHONY target means it is always re-run. | ||
| 69 | + # Without the check there is a race condition between the link being deleted | ||
| 70 | + # and recreated which can break the addons build when running test-ci | ||
| 71 | + # See comments on the build-addons target for some more info | ||
| 67 | 72 | $(NODE_EXE): config.gypi out/Makefile | |
| 68 | 73 | $(MAKE) -C out BUILDTYPE=Release V=$(V) | |
| 69 | - ln -fs out/Release/$(NODE_EXE) $@ | ||
| 74 | + if [ ! -r $(NODE_EXE) -o ! -L $(NODE_EXE) ]; then ln -fs out/Release/$(NODE_EXE) $@; fi | ||
| 70 | 75 | ||
| 71 | 76 | $(NODE_G_EXE): config.gypi out/Makefile | |
| 72 | 77 | $(MAKE) -C out BUILDTYPE=Debug V=$(V) | |
| 73 | - ln -fs out/Debug/$(NODE_EXE) $@ | ||
| 78 | + if [ ! -r $(NODE_EXE) -o ! -L $(node_EXE) ]; then ln -fs out/Debug/$(NODE_EXE) $@; fi | ||
| 74 | 79 | ||
| 75 | 80 | out/Makefile: common.gypi deps/uv/uv.gyp deps/http_parser/http_parser.gyp deps/zlib/zlib.gyp deps/v8/build/toolchain.gypi deps/v8/build/features.gypi deps/v8/tools/gyp/v8.gyp node.gyp config.gypi | |
| 76 | 81 | $(PYTHON) tools/gyp_node.py -f make | |
0 commit comments