Commit f46a04c
test: add tests for add/remove header after sent
This change adds tests to make sure an Error is thrown if a header
is added or removed after they are sent.
PR-URL: #8682
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>1 parent e79351c commit f46a04c
2 files changed
Lines changed: 42 additions & 0 deletions
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,21 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + require('../common'); | ||
| 3 | + const assert = require('assert'); | ||
| 4 | + const http = require('http'); | ||
| 5 | + | ||
| 6 | + const server = http.createServer((req, res) => { | ||
| 7 | + assert.doesNotThrow(() => { | ||
| 8 | + res.setHeader('header1', 1); | ||
| 9 | + }); | ||
| 10 | + res.write('abc'); | ||
| 11 | + assert.throws(() => { | ||
| 12 | + res.setHeader('header2', 2); | ||
| 13 | + }, /Can't set headers after they are sent\./); | ||
| 14 | + res.end(); | ||
| 15 | + }); | ||
| 16 | + | ||
| 17 | + server.listen(0, () => { | ||
| 18 | + http.get({port: server.address().port}, () => { | ||
| 19 | + server.close(); | ||
| 20 | + }); | ||
| 21 | + }); | ||
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,21 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + require('../common'); | ||
| 3 | + const assert = require('assert'); | ||
| 4 | + const http = require('http'); | ||
| 5 | + | ||
| 6 | + const server = http.createServer((req, res) => { | ||
| 7 | + assert.doesNotThrow(() => { | ||
| 8 | + res.removeHeader('header1', 1); | ||
| 9 | + }); | ||
| 10 | + res.write('abc'); | ||
| 11 | + assert.throws(() => { | ||
| 12 | + res.removeHeader('header2', 2); | ||
| 13 | + }, /Can't remove headers after they are sent/); | ||
| 14 | + res.end(); | ||
| 15 | + }); | ||
| 16 | + | ||
| 17 | + server.listen(0, () => { | ||
| 18 | + http.get({port: server.address().port}, () => { | ||
| 19 | + server.close(); | ||
| 20 | + }); | ||
| 21 | + }); | ||
0 commit comments