Commit f4777c7
deps: update v8_inspector
Pick the latest v8_inspector [1] with:
* V8 5.1 compatibility
* Modify parse builder templates to make coverity happy
* The whitespace differences in the jinja2 sub-dependency do exist
upstream. I am not sure how I missed them in the original import
(ed2eac).
[1] pavelfeldman/v8_inspector@3b56732
PR-URL: #7118
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>1 parent 643b33b commit f4777c7
3 files changed
Lines changed: 16 additions & 3 deletions
File tree
- deps/v8_inspector/platform
- inspector_protocol
- v8_inspector
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -180,6 +180,11 @@ def create_primitive_type_definition(type): | |||
| 180 | 180 | "integer": "int", | |
| 181 | 181 | "boolean": "bool" | |
| 182 | 182 | } | |
| 183 | + defaults = { | ||
| 184 | + "number": "0", | ||
| 185 | + "integer": "0", | ||
| 186 | + "boolean": "false" | ||
| 187 | + } | ||
| 183 | 188 | jsontypes = { | |
| 184 | 189 | "number": "TypeNumber", | |
| 185 | 190 | "integer": "TypeNumber", | |
@@ -195,6 +200,7 @@ def create_primitive_type_definition(type): | |||
| 195 | 200 | "raw_type": typedefs[type], | |
| 196 | 201 | "raw_pass_type": typedefs[type], | |
| 197 | 202 | "raw_return_type": typedefs[type], | |
| 203 | + "default_value": defaults[type] | ||
| 198 | 204 | } | |
| 199 | 205 | ||
| 200 | 206 | type_definitions = {} | |
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -187,7 +187,14 @@ public: | |||
| 187 | 187 | } | |
| 188 | 188 | ||
| 189 | 189 | private: | |
| 190 | - {{type.id}}() { } | ||
| 190 | + {{type.id}}() | ||
| 191 | + { | ||
| 192 | + {% for property in type.properties %} | ||
| 193 | + {% if not(property.optional) and "default_value" in resolve_type(property) %} | ||
| 194 | + m_{{property.name}} = {{resolve_type(property).default_value}}; | ||
| 195 | + {%endif %} | ||
| 196 | + {% endfor %} | ||
| 197 | + } | ||
| 191 | 198 | ||
| 192 | 199 | {% for property in type.properties %} | |
| 193 | 200 | {% if property.optional %} | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,7 @@ | |||
| 7 | 7 | ||
| 8 | 8 | #include <v8.h> | |
| 9 | 9 | ||
| 10 | - #if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2) | ||
| 10 | + #if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1) | ||
| 11 | 11 | namespace v8 { | |
| 12 | 12 | ||
| 13 | 13 | // In standalone V8 inspector this is expected to be noop anyways... | |
@@ -23,6 +23,6 @@ class V8_EXPORT MicrotasksScope { | |||
| 23 | 23 | ||
| 24 | 24 | } // namespace v8 | |
| 25 | 25 | ||
| 26 | - #endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2) | ||
| 26 | + #endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1) | ||
| 27 | 27 | ||
| 28 | 28 | #endif // V8Compat_h | |
0 commit comments