Commit f4f210a
build: store cache on timed out builds on Travis
Building Node.js without a ccache cache takes longer than the 50 minute
Travis time limit for jobs for public repositories. To mitigate this we
added a job to compile V8 on the basis that in the worst case it would
complete within 50 minutes and provide a cache that could be used by a
restarted `Compile Node.js` job.
Recent PRs have exceeded the 50 minute time limit for the `Compile V8`
job. When Travis times out a build the cache is not stored.
This commit drops the `Compile V8` job and adds a manual timeout to the
`Compile Node.js` job which will allow the cache to be stored and used
in restarts of the job.
PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>1 parent 0d12e9c commit f4f210a
1 file changed
Lines changed: 8 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,9 +1,3 @@ | |||
| 1 | - x-ccache-setup-steps: &ccache-setup-steps | ||
| 2 | - - export CCACHE_NOSTATS=1 | ||
| 3 | - - export CCACHE_SLOPPINESS="file_macro,include_file_mtime,include_file_ctime,time_macros,file_stat_matches" | ||
| 4 | - - export CC='ccache gcc-6' | ||
| 5 | - - export CXX='ccache g++-6' | ||
| 6 | - | ||
| 7 | 1 | os: linux | |
| 8 | 2 | language: cpp | |
| 9 | 3 | env: | |
@@ -13,33 +7,24 @@ env: | |||
| 13 | 7 | jobs: | |
| 14 | 8 | include: | |
| 15 | 9 | - stage: "Compile" | |
| 16 | - name: "Compile V8" | ||
| 10 | + name: "Compile Node.js" | ||
| 17 | 11 | cache: ccache | |
| 18 | 12 | addons: | |
| 19 | 13 | apt: | |
| 20 | 14 | sources: | |
| 21 | 15 | - ubuntu-toolchain-r-test | |
| 22 | 16 | packages: | |
| 23 | 17 | - g++-6 | |
| 24 | - install: *ccache-setup-steps | ||
| 25 | - script: | ||
| 26 | - - pyenv global ${PYTHON_VERSION} | ||
| 27 | - - ./configure | ||
| 28 | - - make -j2 -C out V=1 v8 | ||
| 29 | - | ||
| 30 | - - name: "Compile Node.js" | ||
| 31 | - cache: ccache | ||
| 32 | - addons: | ||
| 33 | - apt: | ||
| 34 | - sources: | ||
| 35 | - - ubuntu-toolchain-r-test | ||
| 36 | - packages: | ||
| 37 | - - g++-6 | ||
| 38 | - install: *ccache-setup-steps | ||
| 18 | + install: | ||
| 19 | + - export CCACHE_NOSTATS=1 | ||
| 20 | + - export CCACHE_SLOPPINESS="file_macro,include_file_mtime,include_file_ctime,time_macros,file_stat_matches" | ||
| 21 | + - export CC='ccache gcc-6' | ||
| 22 | + - export CXX='ccache g++-6' | ||
| 39 | 23 | script: | |
| 40 | 24 | - pyenv global ${PYTHON_VERSION} | |
| 41 | 25 | - ./configure | |
| 42 | - - make -j2 V=1 | ||
| 26 | + - timeout --preserve-status 45m make -j2 V=1 | ||
| 27 | + before_cache: | ||
| 43 | 28 | - cp out/Release/node /home/travis/.ccache | |
| 44 | 29 | - cp out/Release/cctest /home/travis/.ccache | |
| 45 | 30 | ||
0 commit comments