Commit f50a55d
test: keep finalization close fixture ref alive
The close fixture expects the registered object to still be reachable
when the process emits exit. Keep a strong reference outside setup() so
the assertion does not depend on platform-specific GC timing.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
PR-URL: #64085
Refs: https://github.com/nodejs/reliability/issues?q=%22test-process-finalization%22
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>1 parent 3085714 commit f50a55d
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,9 @@ | |||
| 1 | 1 | import { strictEqual } from 'assert' | |
| 2 | 2 | ||
| 3 | + let obj | ||
| 4 | + | ||
| 3 | 5 | function setup() { | |
| 4 | - const obj = { foo: 'bar' } | ||
| 6 | + obj = { foo: 'bar' } | ||
| 5 | 7 | process.finalization.register(obj, shutdown) | |
| 6 | 8 | } | |
| 7 | 9 | ||
@@ -14,5 +16,6 @@ function shutdown(obj) { | |||
| 14 | 16 | setup() | |
| 15 | 17 | ||
| 16 | 18 | process.on('exit', function () { | |
| 19 | + strictEqual(obj.foo, 'bar') | ||
| 17 | 20 | strictEqual(shutdownCalled, true) | |
| 18 | 21 | }) | |
0 commit comments