Commit f5384c3
src: fix nullptr access on realm
Adding the per-realm binding data tracking introduced a call to a realm
method when realm was potentially null. This is triggered whenever the
function is called from `ContextifyContext::New` which passes `nullptr`
as the `realm`.
PR-URL: #48802
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 629132d commit f5384c3
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -547,7 +547,7 @@ void Environment::AssignToContext(Local<v8::Context> context, | |||
| 547 | 547 | // Used to retrieve bindings | |
| 548 | 548 | context->SetAlignedPointerInEmbedderData( | |
| 549 | 549 | ContextEmbedderIndex::kBindingDataStoreIndex, | |
| 550 | - realm->binding_data_store()); | ||
| 550 | + realm != nullptr ? realm->binding_data_store() : nullptr); | ||
| 551 | 551 | ||
| 552 | 552 | // ContextifyContexts will update this to a pointer to the native object. | |
| 553 | 553 | context->SetAlignedPointerInEmbedderData( | |
0 commit comments