Commit f55380a
deps: V8: cherry-pick f8d5e576b814
Original commit message:
Fix build with older versions of GCC.
This ports the change from bazel on v8:
https://crrev.com/c/3368869
Compilation errors started showing after this CL:
https://crrev.com/c/5199515
Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#92252}
Refs: v8/v8@f8d5e57
PR-URL: #52183
Refs: v8/v8@c4be0a9
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51362
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>1 parent b9d806a commit f55380a
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ | |||
| 37 | 37 | ||
| 38 | 38 | # Reset this number to 0 on major V8 upgrades. | |
| 39 | 39 | # Increment by one for each non-official patch applied to deps/v8. | |
| 40 | - 'v8_embedder_string': '-node.7', | ||
| 40 | + 'v8_embedder_string': '-node.8', | ||
| 41 | 41 | ||
| 42 | 42 | ##### V8 defaults for Node.js ##### | |
| 43 | 43 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1696,6 +1696,10 @@ config("toolchain") { | |||
| 1696 | 1696 | # of `this` in capture-by-value lambdas and preventing a build roll which | |
| 1697 | 1697 | # enables C++20 (see https://crbug.com/1374227). | |
| 1698 | 1698 | "-Wno-deprecated", | |
| 1699 | + | ||
| 1700 | + # Fix build with older versions of GCC | ||
| 1701 | + # Ported from v8 bazel: https://crrev.com/c/3368869 | ||
| 1702 | + "-Wno-stringop-overflow", | ||
| 1699 | 1703 | ] | |
| 1700 | 1704 | } | |
| 1701 | 1705 | ||
0 commit comments