fs: refactor handleTimestampsAndMode to remove redundant call · nodejs/node@f568384 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f568384

Browse filesBrowse the repository at this point in the historyBrowse files

rayark1

authored and

targos

committed

fs: refactor handleTimestampsAndMode to remove redundant call

Refactored the `handleTimestampsAndMode` function to eliminate the redundant `setDestTimestampsAndMode` call. This simplifies the function by ensuring that `setDestTimestampsAndMode` is only called once after any necessary modifications to file writability. PR-URL: #54369 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

1 parent 82d8051 commit f568384
Copy full SHA for f568384

1 file changed

-1Lines changed: 0 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/fs/cp
  • cp.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/fs/cp/cp.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/cp/cp.js

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -270,7 +270,6 @@ async function handleTimestampsAndMode(srcMode, src, dest) {
270	270	// (through utimes call)
271	271	if (fileIsNotWritable(srcMode)) {
272	272	await makeFileWritable(dest, srcMode);
273		- return setDestTimestampsAndMode(srcMode, src, dest);
274	273	}
275	274	return setDestTimestampsAndMode(srcMode, src, dest);
276	275	}

0 commit comments

Comments

0 (0)