Commit f5d1bf9
http: explain the possibilty of refactor unused argument
PR-URL: #37275
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent d63ac28 commit f5d1bf9
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -156,6 +156,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) { | |||
| 156 | 156 | // argument adaptor frame creation inside V8 in case that number of actual | |
| 157 | 157 | // arguments is different from expected arguments. | |
| 158 | 158 | // Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201 | |
| 159 | + // NOTE: Argument adapt frame issue might be solved in V8 engine v8.9. | ||
| 160 | + // Refactoring `n` out might be possible when V8 is upgraded to that | ||
| 161 | + // version. | ||
| 162 | + // Ref: https://v8.dev/blog/v8-release-89 | ||
| 159 | 163 | IncomingMessage.prototype._read = function _read(n) { | |
| 160 | 164 | if (!this._consuming) { | |
| 161 | 165 | this._readableState.readingMore = false; | |
0 commit comments