http: fix error message when specifying headerTimeout for createServer · nodejs/node@f5fcd49 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f5fcd49

Browse filesBrowse the repository at this point in the historyBrowse files

nicksia-vgw

authored and

danielleadams

committed

http: fix error message when specifying headerTimeout for createServer

This change fixes the message on the error received when calling http.createServer(...) with a header timeout greater than the request timeout is incorrect. The validation requires that the header timeout is lower than the request timeout, but the error message asks for the opposite. PR-URL: #44163 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

1 parent c51d85e commit f5fcd49
Copy full SHA for f5fcd49

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_server.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_server.js‎

Copy file name to clipboardExpand all lines: lib/_http_server.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -425,7 +425,7 @@ function storeHTTPOptions(options) {
425	425	}
426	426
427	427	if (this.requestTimeout > 0 && this.headersTimeout > 0 && this.headersTimeout >= this.requestTimeout) {
428		- throw new codes.ERR_OUT_OF_RANGE('headersTimeout', '>= requestTimeout', headersTimeout);
	428	+ throw new codes.ERR_OUT_OF_RANGE('headersTimeout', '< requestTimeout', headersTimeout);
429	429	}
430	430
431	431	const keepAliveTimeout = options.keepAliveTimeout;

0 commit comments

Comments

0 (0)