crypto: forbid passing `Float16Array` to `getRandomValues()` · nodejs/node@f606352 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f606352

Browse filesBrowse the repository at this point in the historyBrowse files

LiviaMedeiros

authored and

aduh95

committed

crypto: forbid passing Float16Array to getRandomValues()

PR-URL: #57880 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

1 parent 43490c8 commit f606352
Copy full SHA for f606352

3 files changed

+4-8Lines changed: 4 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/crypto
  • random.js
• test/wpt
  • status
    • WebCryptoAPI.cjs
  • test-webcrypto.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/crypto/random.js‎

Copy file name to clipboardExpand all lines: lib/internal/crypto/random.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -57,6 +57,7 @@ const {
57	57	isArrayBufferView,
58	58	isAnyArrayBuffer,
59	59	isTypedArray,
	60	+ isFloat16Array,
60	61	isFloat32Array,
61	62	isFloat64Array,
62	63	} = require('internal/util/types');
@@ -315,6 +316,7 @@ function onJobDone(buf, callback, error) {
315	316	// be an integer-type TypedArray.
316	317	function getRandomValues(data) {
317	318	if (!isTypedArray(data) ||
	319	+ isFloat16Array(data) ||
318	320	isFloat32Array(data) ||
319	321	isFloat64Array(data)) {
320	322	// Ordinarily this would be an ERR_INVALID_ARG_TYPE. However,

Collapse file

‎test/wpt/status/WebCryptoAPI.cjs‎

Copy file name to clipboardExpand all lines: test/wpt/status/WebCryptoAPI.cjs

-8Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -11,14 +11,6 @@ module.exports = {
11	11	'historical.any.js': {
12	12	'skip': 'Not relevant in Node.js context',
13	13	},
14		- 'getRandomValues.any.js': {
15		- 'fail': {
16		- 'note': 'Node.js does not support Float16Array',
17		- 'expected': [
18		- 'Float16 arrays',
19		- ],
20		- },
21		- },
22	14	'sign_verify/eddsa_small_order_points.https.any.js': {
23	15	'fail': {
24	16	'note': 'see https://github.com/nodejs/node/issues/54572',

Collapse file

‎test/wpt/test-webcrypto.js‎

Copy file name to clipboardExpand all lines: test/wpt/test-webcrypto.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,3 +1,5 @@
	1	+ // Flags: --js-float16array
	2	+ // TODO(LiviaMedeiros): once `Float16Array` is unflagged in v8, remove the line above
1	3	'use strict';
2	4
3	5	const common = require('../common');

0 commit comments

Comments

0 (0)