Commit f62e35f
src: fix warning in cares_wrap.cc
This commit fixes the following warning:
./src/cares_wrap.cc:1268:5: warning: comparison of integers of
different signs: 'uint32_t' (aka 'unsigned int') and 'int'
[-Wsign-compare]
CHECK_EQ(ret->Length(), a_count + aaaa_count);
PR-URL: #25230
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent be45469 commit f62e35f
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1212,15 +1212,15 @@ class QueryAnyWrap: public QueryWrap { | |||
| 1212 | 1212 | ret, | |
| 1213 | 1213 | addrttls, | |
| 1214 | 1214 | &naddrttls); | |
| 1215 | - int a_count = ret->Length(); | ||
| 1215 | + uint32_t a_count = ret->Length(); | ||
| 1216 | 1216 | if (status != ARES_SUCCESS && status != ARES_ENODATA) { | |
| 1217 | 1217 | ParseError(status); | |
| 1218 | 1218 | return; | |
| 1219 | 1219 | } | |
| 1220 | 1220 | ||
| 1221 | 1221 | if (type == ns_t_a) { | |
| 1222 | - CHECK_EQ(naddrttls, a_count); | ||
| 1223 | - for (int i = 0; i < a_count; i++) { | ||
| 1222 | + CHECK_EQ(static_cast<uint32_t>(naddrttls), a_count); | ||
| 1223 | + for (uint32_t i = 0; i < a_count; i++) { | ||
| 1224 | 1224 | Local<Object> obj = Object::New(env()->isolate()); | |
| 1225 | 1225 | obj->Set(context, | |
| 1226 | 1226 | env()->address_string(), | |
@@ -1234,7 +1234,7 @@ class QueryAnyWrap: public QueryWrap { | |||
| 1234 | 1234 | ret->Set(context, i, obj).FromJust(); | |
| 1235 | 1235 | } | |
| 1236 | 1236 | } else { | |
| 1237 | - for (int i = 0; i < a_count; i++) { | ||
| 1237 | + for (uint32_t i = 0; i < a_count; i++) { | ||
| 1238 | 1238 | Local<Object> obj = Object::New(env()->isolate()); | |
| 1239 | 1239 | obj->Set(context, | |
| 1240 | 1240 | env()->value_string(), | |
@@ -1258,13 +1258,13 @@ class QueryAnyWrap: public QueryWrap { | |||
| 1258 | 1258 | ret, | |
| 1259 | 1259 | addr6ttls, | |
| 1260 | 1260 | &naddr6ttls); | |
| 1261 | - int aaaa_count = ret->Length() - a_count; | ||
| 1261 | + uint32_t aaaa_count = ret->Length() - a_count; | ||
| 1262 | 1262 | if (status != ARES_SUCCESS && status != ARES_ENODATA) { | |
| 1263 | 1263 | ParseError(status); | |
| 1264 | 1264 | return; | |
| 1265 | 1265 | } | |
| 1266 | 1266 | ||
| 1267 | - CHECK_EQ(aaaa_count, naddr6ttls); | ||
| 1267 | + CHECK_EQ(aaaa_count, static_cast<uint32_t>(naddr6ttls)); | ||
| 1268 | 1268 | CHECK_EQ(ret->Length(), a_count + aaaa_count); | |
| 1269 | 1269 | for (uint32_t i = a_count; i < ret->Length(); i++) { | |
| 1270 | 1270 | Local<Object> obj = Object::New(env()->isolate()); | |
0 commit comments