Commit f679ac1
n-api: resolve promise in test
The last promise created by the test for the purposes of making sure
that its type is indeed a promise needs to be resolved so as to avoid
having it left in the pending state at the end of the test.
PR-URL: #19245
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 84ae59e commit f679ac1
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -45,7 +45,9 @@ common.crashOnUnhandledRejection(); | |||
| 45 | 45 | test_promise.concludeCurrentPromise(Promise.resolve('chained answer'), true); | |
| 46 | 46 | } | |
| 47 | 47 | ||
| 48 | - assert.strictEqual(test_promise.isPromise(test_promise.createPromise()), true); | ||
| 48 | + const promiseTypeTestPromise = test_promise.createPromise(); | ||
| 49 | + assert.strictEqual(test_promise.isPromise(promiseTypeTestPromise), true); | ||
| 50 | + test_promise.concludeCurrentPromise(undefined, true); | ||
| 49 | 51 | ||
| 50 | 52 | const rejectPromise = Promise.reject(-1); | |
| 51 | 53 | const expected_reason = -1; | |
0 commit comments